Théophane Hufschmitt
f60b215639
Merge pull request #8310 from obsidiansystems/fix-8141
...
Fix `nix print-dev-env` & `nix develop` with drv paths
2023-05-10 18:01:29 +02:00
John Ericson
a93110ab19
Fix nix print-dev-env
& nix develop
with drv paths
...
Fixes #8309
This regression was because both `CmdDevelop` and `CmdPrintDevEnv` were
switched to be `InstallableValueCommand` subclasses, but actually
neither should have been.
The `nixpkgsFlakeRef` method should indeed not be on the base
installable class, because "flake refs" and "nixpkgs" are not
installable-wide notions, but that doesn't mean these commands should
only accept installable values.
2023-05-10 11:29:45 -04:00
John Ericson
53a1354acf
Merge pull request #3959 from obsidiansystems/ca-drv-exotic
...
Derivations can output "text-hashed" data
2023-05-10 10:41:59 -04:00
Théophane Hufschmitt
85ff212051
Merge pull request #7721 from yorickvP/post-build-hook
...
Also pass unwanted outputs to post-build-hook
2023-05-10 14:30:42 +02:00
John Ericson
6a3a87a714
Improve error message for self reference with text hashing
...
The `ContentAddressWithReferences` method is made total, with error
handling now squarely the caller's job. This is better.
2023-05-09 14:44:08 -04:00
John Ericson
e514b3939a
Add name to some error messages
2023-05-09 13:24:53 -04:00
John Ericson
753fc1661d
Cleanups to content address types
2023-05-09 13:05:38 -04:00
John Ericson
d3c125e5a8
Apply suggestions from code review
...
Thanks!
Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
2023-05-09 12:45:51 -04:00
John Ericson
6513f4fe92
Fix bug, newInfo
-> newInfo0
...
It appears we were checking a variable in the process of definining it.
2023-05-09 12:31:36 -04:00
John Ericson
35dcbe1c21
Fix spurious change
...
Didn't mean to use the private name that shouldn't be exposed.
2023-05-09 12:19:03 -04:00
John Ericson
aacde38d2c
Merge pull request #8110 from aakropotkin/quote-reserved
...
Quote reserved keywords when printing expressions
2023-05-09 11:42:44 -04:00
Alex Ameen
82d1d74a85
quote subshell expansion in tests/eval.sh
2023-05-09 10:06:26 -05:00
Alex Ameen
82296f8113
prevent double quotation
2023-05-09 09:59:18 -05:00
Alex Ameen
b72bc4a972
libexpr: quote reserved keys when printing
...
This fixes a bug in commands like `nix eval' which would emit invalid attribute
sets if they contained reserved keywords such as "assert", "let", etc.
These keywords will not be quoted when printed, making them valid expressions.
All keywords recognized by the lexer are quoted except "or", which does not
require quotation.
2023-05-09 09:45:12 -05:00
Robert Hensing
4539ab530a
Merge pull request #8296 from fricklerhandwerk/contributing-idea-approved
...
highlight 'idea approved' issues in contributing guide
2023-05-08 17:00:23 +02:00
John Ericson
b5d9ef0a4c
Merge pull request #3921 from obsidiansystems/trustless-remote-builder-simple
...
Trustless remote building for input-addressed drvs
2023-05-08 10:43:37 -04:00
John Ericson
df53a7d268
Split comment, match with each variable
2023-05-08 10:08:01 -04:00
John Ericson
cd0d8e0bd5
Apply suggestions from code review
...
Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
2023-05-08 09:57:05 -04:00
John Ericson
278c94d607
Rename a few things in new tests
...
Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
2023-05-08 08:01:58 -04:00
Yorick
d1ff33d2d6
tests/post-hook: remove TODO and --derivation upload
2023-05-08 12:58:59 +02:00
Yorick
5e332aa503
tests: copying only the out paths is not enough information for CA
2023-05-08 12:58:59 +02:00
Yorick
12685ef45f
CA: rewrite hashes for all outputs, not just the wanted ones
2023-05-08 12:58:59 +02:00
Yorick
2ca2c80c4e
libstore: also pass unwanted outputs to the post-build-hook
2023-05-08 12:58:59 +02:00
Yorick
869fb1a2f6
tests/post-hook: test to see if all outputs are passed
...
fe5509df
caused only wanted outputs to be passed to the
post-build-hook, which resulted in paths being built
without ever going into the hook.
This commit adds a (currently failing) test for this.
2023-05-08 12:43:56 +02:00
Robert Hensing
cf8effdae2
Merge pull request #8263 from frederictobiasc/improve-doc-genericclosure
...
Documentation: Improve builtins.genericClosure
2023-05-08 12:23:19 +02:00
Robert Hensing
879e45247c
Merge pull request #8288 from figsoda/regex
...
Fix hostRegex to accept hosts with a `-`
2023-05-08 12:14:59 +02:00
Valentin Gagarin
7c03285719
Update CONTRIBUTING.md
...
Co-authored-by: Théophane Hufschmitt <7226587+thufschmitt@users.noreply.github.com>
2023-05-06 14:24:49 +02:00
Valentin Gagarin
0fad8f71c4
highlight 'idea approved' issues in contributing guide
2023-05-05 14:15:29 +02:00
Théophane Hufschmitt
81778c8d55
Merge pull request #6953 from EzraSingh/patch-1
...
Update install-systemd-multi-user.sh
2023-05-05 13:20:22 +02:00
figsoda
0662fd8599
Fix hostRegex to accept hosts with a -
2023-05-03 18:59:44 -04:00
Eelco Dolstra
b17c4290cf
Merge pull request #8286 from fricklerhandwerk/uninstall-redirects
...
add redirect to track moved uninstall section
2023-05-03 14:09:33 +02:00
Valentin Gagarin
dc8191ae14
add redirect to track moved uninstall section
2023-05-03 11:39:29 +02:00
Valentin Gagarin
5d78dc4176
doc rendering: add functions to scope explicitly ( #7378 )
...
* doc rendering: add functions to scope explicitly
this especially helps beginners with code readability, since the origin
of names is always immediately visible.
2023-05-03 07:16:29 +00:00
Théophane Hufschmitt
1540ab7628
Merge pull request #8282 from fricklerhandwerk/idea-approved
...
maintainers: add procedure for 'idea approved' label
2023-05-02 16:34:01 +02:00
Eelco Dolstra
ba180d7d89
Merge pull request #8270 from edolstra/nix-repair
...
nix: Support the --repair flag
2023-05-02 12:54:08 +02:00
Valentin Gagarin
feb2200ba6
use headings instead of list items
...
this allows easier linking and a provides a bit more visual clarity
2023-05-02 11:30:27 +02:00
Valentin Gagarin
521cca1840
add procedure for 'idea approved' label
2023-05-02 11:28:03 +02:00
Eelco Dolstra
17e6b85d05
nix: Support the --repair flag
2023-04-28 17:03:04 +02:00
Eelco Dolstra
89d3cc5a47
Merge pull request #8267 from fricklerhandwerk/uninstall-instructions
...
move uninstall instructions to a separate page
2023-04-28 12:41:09 +02:00
Valentin Gagarin
9b2a4a4729
move uninstall instructions to a separate page
...
placed in a subsection of the binary install, the instructions are hard
to find. putting them in a separate page that is shown in the table of
contents should make it easier for users to find what they need when
they need it.
2023-04-28 11:53:38 +02:00
Frédéric Christ
f0d2b7eef3
Doc: Improve builtins.genericClosure
2023-04-26 09:37:32 +02:00
Eelco Dolstra
946fd29422
Merge pull request #8260 from edolstra/lazy-trees-cherrypicks
...
lazy-trees cherrypicks
2023-04-25 17:36:53 +02:00
Eelco Dolstra
87f676b3a0
Formatting
2023-04-25 16:52:02 +02:00
Eelco Dolstra
a74d397549
nix build --json: Only show non-zero startTime / stopTime
2023-04-25 16:43:47 +02:00
Eelco Dolstra
880e7b8ed6
TarArchive: Remove a duplicate constant and increase the buffer size
2023-04-25 16:43:10 +02:00
Eelco Dolstra
249ce28332
Merge pull request #8172 from edolstra/source-path
...
Backport `SourcePath` from the lazy-trees branch
2023-04-24 14:05:51 +02:00
Eelco Dolstra
5d3f6dbf59
Add some more SourcePath docs
2023-04-24 13:37:51 +02:00
Eelco Dolstra
ad57cff9bc
Document tMisc
...
Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
2023-04-24 13:34:46 +02:00
Eelco Dolstra
01232358ff
Merge remote-tracking branch 'origin/master' into source-path
2023-04-24 13:20:36 +02:00
Théophane Hufschmitt
7474a90db6
Merge pull request #7710 from obsidiansystems/context-not-path-set
...
Use `std::set<StringContextElem>` not `PathSet` for string contexts
2023-04-21 08:14:58 +02:00