lix-project/lix-website
3
1
Fork 12
Code Issues 2 Pull requests 3 Packages Projects Releases Wiki Activity

Remove height and weight override from Mastodon and Git logos #16

Merged
raito merged 2 commits from val/lix-website:icon-height into main 2024-06-09 13:11:16 +00:00
Conversation 2 Commits 2 Files changed 2 +2 -2
val commented 2024-05-06 21:17:50 +00:00
Contributor
Copy link

The width does nothing as far as I can tell, and the height makes
the clickable boxes much higher than they need to, overlapping with
the paragraph before the button in the footer.

I see this on both Firefox and Chromium:

The width does nothing as far as I can tell, and the height makes the clickable boxes much higher than they need to, overlapping with the paragraph before the button in the footer. I see this on both Firefox and Chromium:
screenshot-2024-05-06_23-11-51.png
106 KiB
screenshot-2024-05-06_23-15-54.png
138 KiB
screenshot-2024-05-06_23-11-51.png screenshot-2024-05-06_23-15-54.png
val added 1 commit 2024-05-06 21:17:56 +00:00 
The width does nothing as far as I can tell, and the height makes
the clickable boxes much higher than they need to, overlapping with
the paragraph before the button in the footer.
danderson commented 2024-05-06 23:10:51 +00:00
Contributor
Copy link

weight and height are needed for WebKit (Safari) to render the icons properly, I wrote up the detail in #8. I suggest updating to use the right dimensions instead? Quick way to find out what they are is to remove width/height and look at the firefox or chrome inspector's layout debugger, it'll list the computed size of the logos in px.

weight and height are needed for WebKit (Safari) to render the icons properly, I wrote up the detail in #8. I suggest updating to use the right dimensions instead? Quick way to find out what they are is to remove width/height and look at the firefox or chrome inspector's layout debugger, it'll list the computed size of the logos in px.
val added 1 commit 2024-05-09 06:20:46 +00:00
raito approved these changes 2024-06-09 13:10:59 +00:00
raito commented 2024-06-09 13:11:04 +00:00
Owner
Copy link

Seems easy to test.

Seems easy to test.
raito merged commit 116e2cbd61 into main 2024-06-09 13:11:16 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
raito
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lix-project/lix-website#16
No description provided.
Delete branch "val/lix-website:icon-height"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?