Matrix icon in footer is invisible #8

New issue

Closed

opened 2024-05-06 03:59:06 +00:00 by winter · 2 comments

winter commented

2024-05-06 03:59:06 +00:00

Member

No description provided.

IMG_4967.jpeg

27 KiB

danderson commented

2024-05-06 06:34:07 +00:00

Contributor

Seems to render correctly in {firefox,chrome}x{nixos,android,macos}, but fails on Safari+macOS and all browsers on iOS (per Apple policy they're forced to use Safari's rendering engine).

Poking around in the inspector, it's because the Matrix <svg> elements doesn't have width and height attributes, so Safari renders it as a 0x0 element. Setting an explicit 16x16 viewport makes Safari render correctly, and doesn't seem to break {firefox,chrome}x{nixos}. I'll send a PR

Seems to render correctly in {firefox,chrome}x{nixos,android,macos}, but fails on Safari+macOS and all browsers on iOS (per Apple policy they're forced to use Safari's rendering engine). Poking around in the inspector, it's because the Matrix `<svg>` elements doesn't have `width` and `height` attributes, so Safari renders it as a 0x0 element. Setting an explicit 16x16 viewport makes Safari render correctly, and doesn't seem to break {firefox,chrome}x{nixos}. I'll send a PR

danderson commented

2024-05-06 06:47:58 +00:00

Contributor

Further detail: the SVG 2 spec introduced the auto value for width/height, to calculate the viewport dimensions based on content dimensions: https://www.w3.org/TR/SVG2/embedded.html#Placement

Firefox and Chrome seem to default width/height for svg elements to auto, whereas Safari doesn't (maybe sticks with SVG 1.1 behavior?) and so the viewport collapses into a singularity unless explicitly expanded.

Further detail: the SVG 2 spec introduced the `auto` value for width/height, to calculate the viewport dimensions based on content dimensions: https://www.w3.org/TR/SVG2/embedded.html#Placement Firefox and Chrome seem to default width/height for svg elements to `auto`, whereas Safari doesn't (maybe sticks with SVG 1.1 behavior?) and so the viewport collapses into a singularity unless explicitly expanded.