lix-project/flake-compat
16
2
Fork 4
Code Issues 15 Pull requests Projects Releases Packages Wiki Activity

treefmt: add python linting because ruff format doesn't do everything #70

Merged
jade merged 1 commit from just1602/flake-compat:add-python-lint-treefmt into main 2025-03-26 16:06:20 +00:00
Conversation 3 Commits 1 Files changed 4 +15 -5
just1602 commented 2025-03-26 04:02:32 +00:00
Member
Copy link

@cobaltcause point out on matrix that ruff format doesn't order imports,
and doesn't run lints.

This commit add a new treefmt formatter to lint the code (for now only
order imports), but more lints could be enable. I tried to enable ALL,
but it's too much and enforce docstring and stuff we may don't want
especially for a testsuite.

@cobaltcause point out on matrix that `ruff format` doesn't order imports, and doesn't run lints. This commit add a new treefmt formatter to lint the code (for now only order imports), but more lints could be enable. I tried to enable `ALL`, but it's too much and enforce docstring and stuff we may don't want especially for a testsuite.
Charles point out on matrix that `ruff format` doesn't order imports,
and doesn't run lints.

This commit add a new treefmt formatter to lint the code (for now only
order imports), but more lint could be enable. I tried to enable `ALL`,
but it's too much and enforce docstring and stuff we may don't want
especially for a testsuite.
just1602 force-pushed add-python-lint-treefmt from 847adf2d1b to b582fd9a71 2025-03-26 04:03:01 +00:00 Compare
jade reviewed 2025-03-26 06:56:44 +00:00
treefmt.toml Outdated
@ -9,0 +11,4 @@
# complain about a lot of things for now.
[formatter.python-lint]
command = "ruff"
options = ["check", "--fix", "--select", "I"]
jade commented 2025-03-26 06:56:44 +00:00
Owner
Copy link

should be in pyproject.toml instead so ruff gets the right settings when used from elsewhere. otherwise this is ok.

should be in pyproject.toml instead so ruff gets the right settings when used from elsewhere. otherwise this is ok.
just1602 force-pushed add-python-lint-treefmt from b582fd9a71 to c5dd2240ab 2025-03-26 15:29:04 +00:00 Compare
just1602 commented 2025-03-26 15:30:26 +00:00
Author
Member
Copy link

Oh, TIL. I don't do a lot of python anymore except for small script, but this is really cool to be able to set stuff up in pyproject.toml like that.

Oh, TIL. I don't do a lot of python anymore except for small script, but this is really cool to be able to set stuff up in `pyproject.toml` like that.
jade approved these changes 2025-03-26 16:06:15 +00:00
jade merged commit 0c79ecade7 into main 2025-03-26 16:06:20 +00:00
just1602 deleted branch add-python-lint-treefmt 2025-03-26 18:00:19 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jade
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lix-project/flake-compat#70
No description provided.
Delete branch "just1602/flake-compat:add-python-lint-treefmt"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?