lix-project/flake-compat
16
0
Fork 0
Code Issues 13 Pull requests Packages Projects Releases Wiki Activity

Support fetching file type flakes #44

Closed
matthewbauer wants to merge 5 commits from matthewbauer/support-fetching-file-type-flakes into master
pull from: matthewbauer/support-fetching-file-type-flakes
merge into: lix-project:master
Conversation 4 Commits 5 Files changed 1 +57 -2
matthewbauer commented 2022-08-26 20:06:49 +00:00 (Migrated from github.com)
Copy link

Add supports for new type = "file" locks added in
5b8c1deb18.

Unfortunately, the hash provided by the lock file is a recursive hash,
while fetchurl wants a flat hash. So we have to use a custom fetchurl
function using the builtin:fetchurl builder. Hopefully okay just to
add compat for this very useful lock type.

cc @edolstra

Add supports for new type = "file" locks added in https://github.com/NixOS/nix/commit/5b8c1deb18e0e6fc7a83fb8101cf5fc8dba38843. Unfortunately, the hash provided by the lock file is a recursive hash, while fetchurl wants a flat hash. So we have to use a custom fetchurl function using the builtin:fetchurl builder. Hopefully okay just to add compat for this very useful lock type. cc @edolstra
jakeisnt commented 2023-02-20 16:32:38 +00:00 (Migrated from github.com)
Copy link

Is this ready to merge? Would love to be able to use this

Is this ready to merge? Would love to be able to use this
matthewbauer commented 2023-02-21 18:06:12 +00:00 (Migrated from github.com)
Copy link

Should be! cc @edolstra

Should be! cc @edolstra
zimbatm commented 2023-06-23 07:28:08 +00:00 (Migrated from github.com)
Copy link

Hi, do you mind squashing all your commits? Then I will cherry-pick the patch into https://github.com/nix-community/flake-compat

Hi, do you mind squashing all your commits? Then I will cherry-pick the patch into https://github.com/nix-community/flake-compat
edolstra commented 2023-06-23 09:18:56 +00:00 (Migrated from github.com)
Copy link

Doesn't this cause use of these inputs to be import-from-derivation? That doesn't seem desirable behaviour.

Doesn't this cause use of these inputs to be import-from-derivation? That doesn't seem desirable behaviour.
jade closed this pull request 2024-05-03 02:57:54 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lix-project/flake-compat#44
No description provided.
Delete branch "matthewbauer/support-fetching-file-type-flakes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?