Make Zulip's alertmanager integration closer to matrix-hookshot-adapter's formatting #287
No reviewers
Labels
No labels
Compat/Breaking
Difficulty
Architectural
Difficulty
Easy
Difficulty
Hard
Help Wanted
Kind
Bug
Kind
Documentation
Kind
Enhancement
Kind
Feature
Kind
Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Security
Silenced Alert
Status
Abandoned
Status
Blocked
Status
Need More Info
Status
Postponed
Tracking Issue
No milestone
No project
No assignees
3 participants
Due date
No due date set.
Dependencies
No dependencies set.
Reference
the-distro/infra!287
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "alertmanager-zulip-ng"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
As @delroth asked for, the last commit contains a patch to Zulip to enable an alerting formatting closer to the one we had on Matrix.
I plan to send this change to upstream and discuss a bit first, I surmise they will want to make some parts of it configurable.
hostIdconcept bcc52ecc7ce397bf005ctoa65af4cc0cWIP: Make Zulip's alertmanager integration closer to matrix-hookshot-adapter's formattingto Make Zulip's alertmanager integration closer to matrix-hookshot-adapter's formattingApproval conditional on actual testing to make sure the formatting is good - feel free to apply minor changes without asking me for another look.
a65af4cc0ctof340a3767ePending final formatting validation
The formatting seems wrong
More precisely, the labels contain line breaks, which means that the call to
dedentis useless because there is no common whitespace at the beginning of each line@ -0,0 +83,4 @@+ labels_block = "\n".join(f"- {k}: {v.tame(check_string)}" for k, v in labels.items())+ annotations_block = "\n".join(f"- {k}: {v.tame(check_string)}" for k, v in annotations.items())++ body = dedent(f"""{icon} **{heading}**Should be
Thanks!
f340a3767eto22f1cbb06aIt's now perfect, thank you @tom-hubrecht !