the-distro/floral.systems
1
1
Fork 1
Code Issues Pull requests 2 Packages Projects Releases Wiki Activity

fix: clip corners of gerrit preview image #3

Closed
jakehamilton wants to merge 0 commits from jakehamilton/floral.systems:fix/gerrit-preview-rounded-corners into main
pull from: jakehamilton/floral.systems:fix/gerrit-preview-rounded-corners
merge into: the-distro:main
Conversation 1 Commits - Files changed -
jakehamilton commented 2024-10-23 17:18:55 +00:00
Member
Copy link

The corners of the Gerrit preview image weren't being rounded because the image was overflowing the container that was rounded. Setting overflow-hidden clips the content to make the corners round as intended.

Before

image

After

image

The corners of the Gerrit preview image weren't being rounded because the image was overflowing the container that was rounded. Setting `overflow-hidden` clips the content to make the corners round as intended. <details> <summary>Before</summary> ![image](/attachments/b7e4e8c9-d391-451e-a0d5-98578be82b33) </details> <details> <summary>After</summary> ![image](/attachments/4aa9aa84-b2fd-4d3a-9919-b31baa837b0b) </details>
image.png
140 KiB
image.png
139 KiB
jakehamilton added 1 commit 2024-10-23 17:18:59 +00:00
ckie commented 2024-10-23 18:38:35 +00:00
Member
Copy link

merged

merged
ckie closed this pull request 2024-10-23 18:38:35 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: the-distro/floral.systems#3
No description provided.
Delete branch "jakehamilton/floral.systems:fix/gerrit-preview-rounded-corners"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?