tfausak/lix-installer
0
0
Fork 0
forked from lix-project/lix-installer
Code Pull requests 2 Activity

Fix --init none being ignored on systems without systemd #2

Open
tfausak wants to merge 3 commits from tfausak-2026-03-19-init-none into main
pull from: tfausak-2026-03-19-init-none
merge into: tfausak:main
Conversation 1 Commits 3 Files changed 3 +15 -9
tfausak commented 2026-03-19 19:05:21 +00:00
Owner
Copy link

plan_systemd_init_step() hardcoded InitSystem::Systemd, ignoring the user's --init flag. This caused installs with --init none to fail with "Could not detect systemd" on non-systemd systems.

Rename to plan_init_step() and pass the InitSystem through so that ConfigureInitService::plan() receives the actual setting. When InitSystem::None, empty service/socket lists are used and the action becomes a no-op as intended.

plan_systemd_init_step() hardcoded InitSystem::Systemd, ignoring the user's --init flag. This caused installs with --init none to fail with "Could not detect systemd" on non-systemd systems. Rename to plan_init_step() and pass the InitSystem through so that ConfigureInitService::plan() receives the actual setting. When InitSystem::None, empty service/socket lists are used and the action becomes a no-op as intended.
tfausak commented 2026-03-19 19:09:45 +00:00
Author
Owner
Copy link

This would fix https://git.lix.systems/lix-project/lix-installer/issues/70. I believe the problem was introduced by https://git.lix.systems/lix-project/lix-installer/commit/3b84a8c4b521bcc490cf8f804071c1d9af8d2a3c.

This would fix <https://git.lix.systems/lix-project/lix-installer/issues/70>. I believe the problem was introduced by <https://git.lix.systems/lix-project/lix-installer/commit/3b84a8c4b521bcc490cf8f804071c1d9af8d2a3c>.
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin tfausak-2026-03-19-init-none:tfausak-2026-03-19-init-none
git switch tfausak-2026-03-19-init-none

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff tfausak-2026-03-19-init-none
git switch tfausak-2026-03-19-init-none
git rebase main
git switch main
git merge --ff-only tfausak-2026-03-19-init-none
git switch tfausak-2026-03-19-init-none
git rebase main
git switch main
git merge --no-ff tfausak-2026-03-19-init-none
git switch main
git merge --squash tfausak-2026-03-19-init-none
git switch main
git merge --ff-only tfausak-2026-03-19-init-none
git switch main
git merge tfausak-2026-03-19-init-none
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
tfausak/lix-installer!2
No description provided.