30dcc19d1f
I think it is bad for these reasons when `tests/` contains a mix of
functional and integration tests
- Concepts is harder to understand, the documentation makes a good
unit vs functional vs integration distinction, but when the
integration tests are just two subdirs within `tests/` this is not
clear.
- Source filtering in the `flake.nix` is more complex. We need to
filter out some of the dirs from `tests/`, rather than simply pick
the dirs we want and take all of them. This is a good sign the
structure of what we are trying to do is not matching the structure
of the files.
With this change we have a clean:
```shell-session
$ git show 'HEAD:tests'
tree HEAD:tests
functional/
installer/
nixos/
```
(cherry picked from commit 68c81c7375)
4.9 KiB
Contributing to Nix
Welcome and thank you for your interest in contributing to Nix! We appreciate your support.
Reading and following these guidelines will help us make the contribution process easy and effective for everyone involved.
Report a bug
-
Check on the GitHub issue tracker if your bug was already reported.
-
If you were not able to find the bug or feature open a new issue
-
The issue templates will guide you in specifying your issue. The more complete the information you provide, the more likely it can be found by others and the more useful it is in the future. Make sure reported bugs can be reproduced easily.
-
Once submitted, do not expect issues to be picked up or solved right away. The only way to ensure this, is to work on the issue yourself.
Report a security vulnerability
Check out the security policy.
Making changes to Nix
-
Check for pull requests that might already cover the contribution you are about to make. There are many open pull requests that might already do what you intent to work on. You can use labels to filter for relevant topics.
-
Search for related issues that cover what you're going to work on. It could help to mention there that you will work on the issue.
Issues labeled good first issue should be relatively easy to fix and are likely to get merged quickly. Pull requests addressing issues labeled idea approved are especially welcomed by maintainers and will receive prioritised review.
-
Check the Nix reference manual for information on building Nix and running its tests.
For contributions to the command line interface, please check the CLI guidelines.
-
Make your changes!
-
Create a pull request for your changes.
- Link related issues in your pull request to inform interested parties and future contributors about your change.
- Make sure to have a clean history of commits on your branch by using rebase.
If your pull request closes one or multiple issues, note that in the description using
Closes: #<number>, as it will then happen automatically when your change is merged. - Mark the pull request as draft if you're not done with the changes.
-
Do not expect your pull request to be reviewed immediately. Nix maintainers follow a structured process for reviews and design decisions, which may or may not prioritise your work.
Following this checklist will make the process smoother for everyone:
- Fixes an idea approved issue
- Tests, as appropriate:
- Functional tests –
tests/functional/**.sh - Unit tests –
src/*/tests - Integration tests –
tests/nixos/*
- Functional tests –
- User documentation in the manual
- API documentation in header files
- Code and comments are self-explanatory
- Commit message explains why the change was made
- New feature or incompatible change: updated release notes
-
If you need additional feedback or help to getting pull request into shape, ask other contributors using @mentions.
Making changes to the Nix manual
The Nix reference manual is hosted on https://nixos.org/manual/nix.
The underlying source files are located in doc/manual/src.
For small changes you can use GitHub to edit these files
For larger changes see the Nix reference manual.
Getting help
Whenever you're stuck or do not know how to proceed, you can always ask for help. The appropriate channels to do so can be found on the NixOS Community page.