puck/lix
0
0
Fork 0
forked from lix-project/lix
Code Pull requests Activity
15401 commits 19 branches 0 tags 68 MiB
Commit graph

15401 commits

This branch
This branch
All branches
Author SHA1 Message Date
Robert Hensing 251fb23aea Shebang parser: add virtual destructor 
Fixes:

    warning: destructor called on non-final 'nix::ParseUnquoted' that has virtual functions but non-virtual destructor [-Wdelete-non-abstract-non-virtual-dtor]
 2023-11-19 01:48:08 +01:00
Robert Hensing 1d86bb4f70
Merge pull request #9373 from obsidiansystems/fix-make-check 
Fix `make check`
 2023-11-17 19:09:38 +01:00
Robert Hensing 7762335a9c
Merge pull request #9374 from hercules-ci/fix-nogc 
Fix buildNoGc
 2023-11-17 18:16:11 +01:00
Robert Hensing 4a539ac3ea Fix buildNoGc 
Fixes https://hydra.nixos.org/build/241067941/nixlog/1

    src/libexpr/eval.cc:1776:54: error: variable 'boost::container::small_vector<nix::Value*, 4> vArgs' has initializer but incomplete type
 2023-11-17 17:38:08 +01:00
John Ericson 293ae59257 Fix make check 
After 9c7749e135, `libutil-tests_RUN`
doesn't exist. It needs to become `libutil-tests-exe_RUN`.
 2023-11-17 11:26:45 -05:00
Eelco Dolstra 6acc9b11d9
Merge pull request #9372 from edolstra/release-notes 
2.19 release notes
 2023-11-17 14:52:40 +01:00
Théophane Hufschmitt b1e7d7cad6
Merge pull request #9280 from R-VdP/rvdp/fix_remote_logging_phase_reporting 
Include phase reporting in log file for ssh-ng builds
 2023-11-17 14:37:09 +01:00
Eelco Dolstra f7d59d0dda Release notes 2023-11-17 14:21:17 +01:00
Eelco Dolstra 3a7f024a9c
Merge pull request #9363 from edolstra/symlink-regression 
Fix symlink handling
 2023-11-17 14:11:50 +01:00
Robert Hensing d4370d8850
Merge pull request #9368 from frogamic/let-inherit 
doc: Add example of inherit in a let expression
 2023-11-17 11:22:27 +01:00
Robert Hensing 7b0e8c5c2c
Apply suggestions from code review 
Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
 2023-11-17 10:56:23 +01:00
Dominic Shelton c819375769
doc: Add example of inherit in a let expression 2023-11-17 17:50:17 +11:00
Théophane Hufschmitt 7ba4e073e8
Merge pull request #6469 from gbpdt/fix/skipped_build_locking 
Unlock output paths when a derivation is already built
 2023-11-16 21:59:25 +01:00
Théophane Hufschmitt fabae98ab4
Merge pull request #9360 from obsidiansystems/install-unit-tests 
Allow installing unit tests
 2023-11-16 21:25:21 +01:00
Théophane Hufschmitt ac4431e9d0
Merge pull request #7348 from thufschmitt/dont-use-vlas 
Remove the usage of VLAs in the code
 2023-11-16 19:05:37 +01:00
Eelco Dolstra 57de482e00
Merge pull request #9364 from edolstra/fix-coverage 
Fix a broken generated header file dependency
 2023-11-16 17:37:05 +01:00
Eelco Dolstra 96d67620d5 Fix a broken generated header file dependency 
https://hydra.nixos.org/build/240882042
 2023-11-16 17:12:06 +01:00
Eelco Dolstra 31ebc6028b Fix symlink handling 
This restores the symlink handling behaviour prior to
94812cca98.

Fixes #9298.
 2023-11-16 16:45:14 +01:00
John Ericson 6c8f4ef350 Allow installing unit tests 
Closes #9343

See that issue for motivation.

Installing these is disabled by default, but we enable it (and the
additional output we want isntall these too so as not to clutter the
existing ones) to use in cross builds and dev shells.
 2023-11-16 09:55:42 -05:00
Robert Hensing 4e27f1947a libexpr: Reduce nonRecursiveStackReservation 
128 is still beyond the point where the allocation overhead is
insignificant, but we don't anticipate to overflow for these
use cases, so it's fine.
 2023-11-16 15:38:21 +01:00
Robert Hensing a96be29db5 removeAttrs: increase stack reservation to 64 2023-11-16 15:38:21 +01:00
Robert Hensing 1b9813e4e6 primops: Name stack reservation limits 2023-11-16 15:38:21 +01:00
Robert Hensing 898c47384f primops: Err on the side of less stack usage 
Try to stay away from stack overflows.

These small vectors use stack space. Most instances will not need
to allocate because in general most things are small, and large
things are worth heap allocating.

16 * 3 * word = 384 bytes is still quite a bit, but these functions
tend not to be part of deep recursions.
 2023-11-16 15:38:21 +01:00
Robert Hensing 91114a6fa4 ExprCall::eval: Heap allocate at arity 5+ 2023-11-16 15:38:21 +01:00
Robert Hensing 206ece0f41 builtins.{any,all}: Use constant errorCtx 
Clang warned that the expanded code used to have a buffer overflow.
Very strange, but also very avoidable.
 2023-11-16 15:38:21 +01:00
Robert Hensing 9fa133dde5 readProcLink: Replace unnecessary value judgement by actual info 2023-11-16 15:38:21 +01:00
Robert Hensing 12c91a823e maxPrimOpArity: 64 -> 8 
This makes stack usage significantly more compact, allowing larger
amounts of data to be processed on the same stack.

PrimOp functions with more than 8 positional (curried) arguments
should use an attrset instead.
 2023-11-16 15:38:21 +01:00
Eelco Dolstra 2bd2702127
Merge pull request #9354 from vicky1999/fix/8875 
Renamed nix nar dump-path to nix nar pack
 2023-11-16 15:06:33 +01:00
Eelco Dolstra 16c052e4e7
Merge pull request #9307 from flox/tomberek.nix_key_newline 
nix key: no need for progressBar
 2023-11-16 15:05:34 +01:00
Eelco Dolstra c47f769391
Merge pull request #9350 from NixOS/dependabot/github_actions/zeebe-io/backport-action-2.1.1 
build(deps): bump zeebe-io/backport-action from 2.1.0 to 2.1.1
 2023-11-16 15:01:49 +01:00
Robert Hensing 0daccb1121 libexpr: Check primop arity earlier 2023-11-16 12:28:32 +01:00
Théophane Hufschmitt ba3cb4a049 Remove all the occurences of VLAs 
There's generally no strict reason for using them, and they are somewhat
fishy, so let's avoid them.
 2023-11-16 12:27:30 +01:00
Théophane Hufschmitt 5196613e82 Use boost small vectors instead of VLAs in the primops 
VLAs are a dangerous feature, and their usage triggers an undefined
behavior since theire size can be zero in some cases.
So replace them with `boost::small_vector`s which fit the same goal but
are safer.

It's also incidentally consistently 1% faster on the benchmarks.
 2023-11-16 12:27:30 +01:00
John Ericson e34c424279
Merge pull request #9357 from NixOS/nix-store-add 
Add a new `nix store add` command
 2023-11-15 13:49:44 -05:00
Théophane Hufschmitt 84128461b6 Add a new nix store add command 
Deprecate `nix store add-file` and `nix store add-path`, and replace
them with a single `nix store add` command.
 2023-11-15 19:21:17 +01:00
Silvan Mosberger 70b396649c doc: logical implication is right-associative 
nix-repl> bools = [ false true ]

    nix-repl> combinations = builtins.concatMap (a: builtins.concatMap (b: map (c: { inherit a b c; }) bools) bools) bools

    nix-repl> builtins.all ({ a, b, c }: (a -> b -> c) == (a -> (b -> c))) combinations
    true

    nix-repl> builtins.all ({ a, b, c }: (a -> b -> c) == ((a -> b) -> c)) combinations
    false
 2023-11-15 07:04:09 +01:00
John Ericson d23d0a074d
Merge pull request #9355 from obsidiansystems/fix-tiny-libutil-unit-test-make-bug 
Fix makefile bug confusing `libnixutil-test` exe vs lib
 2023-11-14 12:13:41 -05:00
John Ericson 9c7749e135 Fix makefile bug confusing libnixutil-test exe vs lib 
The `-exe` variant is the program, the unsuffixed variant is the
library.

The corrected usage matches `libnixstore-test`.
 2023-11-14 11:45:52 -05:00
vicky1999 e07e3c106a code cleanup 2023-11-14 20:02:33 +05:30
vicky1999 4944cdb94d nar dump-path command renamed to nar pack 2023-11-14 19:59:48 +05:30
Théophane Hufschmitt c889881cbb
Merge pull request #9351 from Trundle/update-chroot-store-comment 
Update comment to reflect bind mounts are now used for store in chroot
 2023-11-14 09:09:27 +01:00
Andreas Stührk ad99c8950b Update comment to reflect bind mounts are now used for store in chroot 2023-11-13 23:29:48 +01:00
dependabot[bot] 742a63b98f
build(deps): bump zeebe-io/backport-action from 2.1.0 to 2.1.1 
Bumps [zeebe-io/backport-action](https://github.com/zeebe-io/backport-action) from 2.1.0 to 2.1.1.
- [Release notes](https://github.com/zeebe-io/backport-action/releases)
- [Commits](https://github.com/zeebe-io/backport-action/compare/v2.1.0...v2.1.1)

---
updated-dependencies:
- dependency-name: zeebe-io/backport-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2023-11-13 22:01:50 +00:00
Tom Bereknyei 0be84c83b2 key and cat: no need for progressBar 
otherwise the output will be invisible in common terminal configurations
 2023-11-12 15:40:44 -05:00
Théophane Hufschmitt 2afe2e4fbc
Merge pull request #9333 from DeterminateSystems/option-for-nix-upgrade-url 
nix upgrade-nix: make the source URL an option
 2023-11-12 19:45:30 +01:00
Graham Christensen fd5a4a8467 nix upgrade-nix: make the source URL an option 
This new option enables organizations to more easily manage their Nix
fleet's deployment, and ensure a consistent and planned rollout of Nix
upgrades.
 2023-11-10 12:12:28 -05:00
John Ericson 458e511dc4
Merge pull request #9294 from obsidiansystems/minimal-git 
Git object hashing in libutil
 2023-11-10 11:24:23 -05:00
John Ericson 20b95d6223 Git object hashing in libutil 
This is the core functionality but just unit-tested and not yet made
part of the store layer. This is because there is some tech debt around
(a) repeated boilerplate hashing objects (b) better integration of the
new `SourceAccessor` type that needs to be cleaned up first.

Part of RFC 133

Co-Authored-By: Matthew Bauer <mjbauer95@gmail.com>
Co-Authored-By: Carlo Nucera <carlo.nucera@protonmail.com>
Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
Co-authored-by: Florian Klink <flokli@flokli.de>
 2023-11-10 11:02:44 -05:00
John Ericson 9afa697ab6 Refactor bash test build system a bit 
The basic idea here is to separate a few intertwined notions:

1. Not all "run bash tests" are "install tests"

2. Not all "run bash tests" use `tests/functional/init.sh`, or any
   pre-test initialization at all.

This will used in the next commit when we have a test that check unit
test golden master data.

Also, move our custom `PS4` from the test to the test runner, as it is
part of how we want to display the tests, not the test themselves.

Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
 2023-11-10 11:02:37 -05:00
John Ericson 3d9d5dc189 Create MemorySink 
This is for writing to a `MemorySourceAccessor`.
 2023-11-10 11:02:37 -05:00