ma27/hydra
0
0
Fork 0
forked from lix-project/hydra
Code Pull requests Activity

Remove the "all" channel

Browse source 
The "all" channel fundamentally doesn't scale, because it needs
to fetch N builds from the database (where N is potentially a very
large number), then check whether they are still valid.  And it's
not very useful anyway.
This commit is contained in:
Eelco Dolstra 2011-11-30 12:07:47 +01:00
parent d37c4cfe86
commit c8d572a0dc
4 changed files with 7 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/lib/Hydra/Base/Controller/ListBuilds.pm
View file

@ -81,10 +81,10 @@ sub nix : Chained('get_builds') PathPart('channel') CaptureArgs(1) {
$c->stash->{channelName} = $c->stash->{channelBaseName} . "-latest"; $c->stash->{channelName} = $c->stash->{channelBaseName} . "-latest";
getChannelData($c, scalar($c->stash->{latestSucceeded})); getChannelData($c, scalar($c->stash->{latestSucceeded}));
} }
elsif ($channelName eq "all") { #elsif ($channelName eq "all") {
$c->stash->{channelName} = $c->stash->{channelBaseName} . "-all"; # $c->stash->{channelName} = $c->stash->{channelBaseName} . "-all";
getChannelData($c, scalar($c->stash->{allBuilds})); # getChannelData($c, scalar($c->stash->{allBuilds}));
} #}
else { else {
notFound($c, "Unknown channel `$channelName'."); notFound($c, "Unknown channel `$channelName'.");
} }

7
src/root/job.tt
View file

@ -31,7 +31,7 @@
[% END %] [% END %]
</div> </div>
<div id="tabs-channels"> <div id="tabs-channels">
<p>This job provides the following Nix channels:</p> <p>This job provides the following Nix channel:</p>
<ul> <ul>
<li> <li>
@ -39,11 +39,6 @@
'channel' 'latest') %]"><tt>latest</tt></a> — contains the latest 'channel' 'latest') %]"><tt>latest</tt></a> — contains the latest
successful build for each platform. successful build for each platform.
</li> </li>
<li>
<a href="[% c.uri_for('/job' project.name jobset.name job.name
'channel' 'all') %]"><tt>all</tt></a> — contains every successful
build of this job.
</li>
</ul> </ul>
</div> </div>
<div id="tabs-latestbuilds"> <div id="tabs-latestbuilds">

7
src/root/jobset.tt
View file

@ -221,7 +221,7 @@
<h2>Channels</h2> <h2>Channels</h2>
<p>This jobset provides the following Nix channels:</p> <p>This jobset provides the following Nix channel:</p>
<ul> <ul>
<li> <li>
@ -229,11 +229,6 @@
'latest') %]"><tt>latest</tt></a> — contains the latest successful 'latest') %]"><tt>latest</tt></a> — contains the latest successful
build of every job in this jobset. build of every job in this jobset.
</li> </li>
<li>
<a href="[% c.uri_for('/jobset' project.name jobset.name 'channel'
'all') %]"><tt>all</tt></a> — contains every successful,
non-garbage-collected build of every job in this project.
</li>
</ul> </ul>
</div> </div>

7
src/root/project.tt
View file

@ -207,18 +207,13 @@
<h2>Channels</h2> <h2>Channels</h2>
<p>This project provides the following Nix channels:</p> <p>This project provides the following Nix channel:</p>
<ul> <ul>
<li> <li>
<a href="[% c.uri_for('/project' project.name 'channel' 'latest') %]"><tt>latest</tt></a> — <a href="[% c.uri_for('/project' project.name 'channel' 'latest') %]"><tt>latest</tt></a> —
contains the latest successful build of every job in this project. contains the latest successful build of every job in this project.
</li> </li>
<li>
<a href="[% c.uri_for('/project' project.name 'channel' 'all') %]"><tt>all</tt></a> —
contains every successful, non-garbage-collected build of every
job in this project.
</li>
</ul> </ul>
</div> </div>