From c8d572a0dcdd1ccd0e5a745a63f8cd9d5c88d38e Mon Sep 17 00:00:00 2001
From: Eelco Dolstra <e.dolstra@tudelft.nl>
Date: Wed, 30 Nov 2011 12:07:47 +0100
Subject: [PATCH] Remove the "all" channel

The "all" channel fundamentally doesn't scale, because it needs
to fetch N builds from the database (where N is potentially a very
large number), then check whether they are still valid.  And it's
not very useful anyway.
---
 src/lib/Hydra/Base/Controller/ListBuilds.pm | 8 ++++----
 src/root/job.tt                             | 7 +------
 src/root/jobset.tt                          | 7 +------
 src/root/project.tt                         | 7 +------
 4 files changed, 7 insertions(+), 22 deletions(-)

diff --git a/src/lib/Hydra/Base/Controller/ListBuilds.pm b/src/lib/Hydra/Base/Controller/ListBuilds.pm
index fa3784cc..fc1a3645 100644
--- a/src/lib/Hydra/Base/Controller/ListBuilds.pm
+++ b/src/lib/Hydra/Base/Controller/ListBuilds.pm
@@ -81,10 +81,10 @@ sub nix : Chained('get_builds') PathPart('channel') CaptureArgs(1) {
             $c->stash->{channelName} = $c->stash->{channelBaseName} . "-latest";
             getChannelData($c, scalar($c->stash->{latestSucceeded}));
         }
-        elsif ($channelName eq "all") {
-            $c->stash->{channelName} = $c->stash->{channelBaseName} . "-all";
-            getChannelData($c, scalar($c->stash->{allBuilds}));
-        }
+        #elsif ($channelName eq "all") {
+        #    $c->stash->{channelName} = $c->stash->{channelBaseName} . "-all";
+        #    getChannelData($c, scalar($c->stash->{allBuilds}));
+        #}
         else {
             notFound($c, "Unknown channel `$channelName'.");
         }
diff --git a/src/root/job.tt b/src/root/job.tt
index 9333302c..38bec904 100644
--- a/src/root/job.tt
+++ b/src/root/job.tt
@@ -31,7 +31,7 @@
 	    [% END %]
 	</div>
 	<div id="tabs-channels">
-		<p>This job provides the following Nix channels:</p>
+		<p>This job provides the following Nix channel:</p>
 		
 		<ul>
 		  <li>
@@ -39,11 +39,6 @@
 		    'channel' 'latest') %]"><tt>latest</tt></a> — contains the latest
 		    successful build for each platform.
 		  </li>
-		  <li>
-		    <a href="[% c.uri_for('/job' project.name jobset.name job.name
-		    'channel' 'all') %]"><tt>all</tt></a> — contains every successful
-		    build of this job.
-		  </li>
 		</ul>
 	</div>
 	<div id="tabs-latestbuilds">
diff --git a/src/root/jobset.tt b/src/root/jobset.tt
index 0cb1f16d..d6e6b35d 100644
--- a/src/root/jobset.tt
+++ b/src/root/jobset.tt
@@ -221,7 +221,7 @@
 		
 			<h2>Channels</h2>
 			
-			<p>This jobset provides the following Nix channels:</p>
+			<p>This jobset provides the following Nix channel:</p>
 			
 			<ul>
 			  <li>
@@ -229,11 +229,6 @@
 			    'latest') %]"><tt>latest</tt></a> — contains the latest successful
 			    build of every job in this jobset.
 			  </li>
-			  <li>
-			    <a href="[% c.uri_for('/jobset' project.name jobset.name 'channel'
-			    'all') %]"><tt>all</tt></a> — contains every successful,
-			    non-garbage-collected build of every job in this project.
-			  </li>
 			</ul>
 			
 		</div>
diff --git a/src/root/project.tt b/src/root/project.tt
index b644ccf0..31d7d8cd 100644
--- a/src/root/project.tt
+++ b/src/root/project.tt
@@ -207,18 +207,13 @@
 			
 			<h2>Channels</h2>
 			
-			<p>This project provides the following Nix channels:</p>
+			<p>This project provides the following Nix channel:</p>
 			
 			<ul>
 			  <li>
 			    <a href="[% c.uri_for('/project' project.name 'channel' 'latest') %]"><tt>latest</tt></a> —
 			    contains the latest successful build of every job in this project.
 			  </li>
-			  <li>
-			    <a href="[% c.uri_for('/project' project.name 'channel' 'all') %]"><tt>all</tt></a> —
-			    contains every successful, non-garbage-collected build of every
-			    job in this project.
-			  </li>
 			</ul>
 			
 		</div>