lix-project/replxx
1
0
Fork 1
Code Issues 2 Pull requests 3 Projects Releases Packages Wiki Activity

fix: always reset umask after failed history_save #1

Open
blokyk wants to merge 1 commit from blokyk/replxx:fix/history-umask into master
pull from: blokyk/replxx:fix/history-umask
merge into: lix-project:master
Conversation 0 Commits 1 Files changed 2 +49 -5
blokyk commented 2026-05-08 01:24:23 +00:00
Member
Copy link

On non-windows platforms, History::save() used umask to ensure it could open the history file, but it didn't reset it in case the open failed, which can mess with the rest of the app's operation if the umask was different before the save() call (which is the case with lix)

On non-windows platforms, `History::save()` used `umask` to ensure it could open the history file, but it didn't reset it in case the open failed, which can mess with the rest of the app's operation if the `umask` was different before the `save()` call (which is the case with lix)
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u fix/history-umask:blokyk-fix/history-umask
git switch blokyk-fix/history-umask

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch master
git merge --no-ff blokyk-fix/history-umask
git switch blokyk-fix/history-umask
git rebase master
git switch master
git merge --ff-only blokyk-fix/history-umask
git switch blokyk-fix/history-umask
git rebase master
git switch master
git merge --no-ff blokyk-fix/history-umask
git switch master
git merge --squash blokyk-fix/history-umask
git switch master
git merge --ff-only blokyk-fix/history-umask
git switch master
git merge blokyk-fix/history-umask
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lix-project/replxx!1
No description provided.