overlay: remove nixos-option from overrides #98

Open
dawnofmidnight wants to merge 1 commit from dawnofmidnight/nixos-module:overlay-remove-nixos-option into main
First-time contributor

nixos-option was originally added as an exception because it linked to CppNix internals, but this is no longer true as of 25.05 (see https://github.com/NixOS/nixpkgs/pull/369151). It now appears to work with Lix, so the override can be removed.

Our testing of this leaves much to be desired since we don't use nixos-option regularly, but basic usage seems to work (on a nixos-unstable system with Lix version 2.94.0pre-243836ed):

~> nixos-option i18n.defaultLocale -I "nixos-config=/etc/nixos/configuration.nix"
fetching path input 'path:/nix/store/c9asdiqw1rf5qwdjz26f57hp68ppb8fc-source'
Value:
  "en_US.UTF-8"

Default:
  "en_US.UTF-8"

Type:
  string

Description:
  The default locale. It determines the language for program messages,
  the format for dates and times, sort order, and so on. Setting the
  default character set is done via {option}`i18n.defaultCharset`.

Example:
  "nl_NL.UTF-8"

Declared by:
  /nix/store/c9asdiqw1rf5qwdjz26f57hp68ppb8fc-source/nixos/modules/config/i18n.nix

Defined by:
  /nix/store/c9asdiqw1rf5qwdjz26f57hp68ppb8fc-source/nixos/modules/config/i18n.nix
nixos-option was originally added as an exception because it linked to CppNix internals, but this is no longer true as of 25.05 (see https://github.com/NixOS/nixpkgs/pull/369151). It now appears to work with Lix, so the override can be removed. Our testing of this leaves much to be desired since we don't use nixos-option regularly, but basic usage seems to work (on a nixos-unstable system with Lix version 2.94.0pre-243836ed): ``` ~> nixos-option i18n.defaultLocale -I "nixos-config=/etc/nixos/configuration.nix" fetching path input 'path:/nix/store/c9asdiqw1rf5qwdjz26f57hp68ppb8fc-source' Value: "en_US.UTF-8" Default: "en_US.UTF-8" Type: string Description: The default locale. It determines the language for program messages, the format for dates and times, sort order, and so on. Setting the default character set is done via {option}`i18n.defaultCharset`. Example: "nl_NL.UTF-8" Declared by: /nix/store/c9asdiqw1rf5qwdjz26f57hp68ppb8fc-source/nixos/modules/config/i18n.nix Defined by: /nix/store/c9asdiqw1rf5qwdjz26f57hp68ppb8fc-source/nixos/modules/config/i18n.nix ```
overlay: remove nixos-option from overrides
Some checks failed
/ build (aarch64-linux) (pull_request) Has been cancelled
/ build (x86_64-linux) (pull_request) Has been cancelled
3a34448994
nixos-option was originally added as an exception because it linked to
CppNix internals, but this is no longer true as of 25.05
(see https://github.com/NixOS/nixpkgs/pull/369151). It now appears to
work with Lix, so the override can be removed.
Some checks failed
/ build (aarch64-linux) (pull_request) Has been cancelled
/ build (x86_64-linux) (pull_request) Has been cancelled
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u overlay-remove-nixos-option:dawnofmidnight-overlay-remove-nixos-option
git switch dawnofmidnight-overlay-remove-nixos-option

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff dawnofmidnight-overlay-remove-nixos-option
git switch dawnofmidnight-overlay-remove-nixos-option
git rebase main
git switch main
git merge --ff-only dawnofmidnight-overlay-remove-nixos-option
git switch dawnofmidnight-overlay-remove-nixos-option
git rebase main
git switch main
git merge --no-ff dawnofmidnight-overlay-remove-nixos-option
git switch main
git merge --squash dawnofmidnight-overlay-remove-nixos-option
git switch main
git merge --ff-only dawnofmidnight-overlay-remove-nixos-option
git switch main
git merge dawnofmidnight-overlay-remove-nixos-option
git push origin main
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lix-project/nixos-module!98
No description provided.