lix-project/nixos-module
17
11
Fork 22
Code Issues 9 Pull requests 1 Projects Releases Packages Wiki Activity

flake: remove flake-utils #70

Open
llakala wants to merge 1 commit from llakala/nixos-module:no-flake-utils into main
pull from: llakala/nixos-module:no-flake-utils
merge into: lix-project:main
Conversation 2 Commits 1 Files changed 1 +45 -28
llakala commented 2025-06-17 19:16:49 +00:00
First-time contributor
Copy link

Less flake.lock bloat.

A few questions:

  • inputs and pkgs are both currently provided as flake inputs. Is that necessary? It seems a little silly.
  • Is there a specific formatter I should use?
Less `flake.lock` bloat. A few questions: - `inputs` and `pkgs` are both currently provided as flake inputs. Is that necessary? It seems a little silly. - Is there a specific formatter I should use?
❤️ 1
jade commented 2025-06-18 02:09:38 +00:00
Owner
Copy link

We might in the future put the QA stuff into a separate directory like our flake-compat does. Otherwise this looks fine(tm), though I've not tested it yet.

We might in the future put the QA stuff into a separate directory like our flake-compat does. Otherwise this looks fine(tm), though I've not tested it yet.
jade requested changes 2025-06-18 02:18:32 +00:00
jade left a comment
Owner
Copy link

re-eval of nixpkgs when evaluating multiple attrs is not ideal, but fixing it is pretty easy.

re-eval of nixpkgs when evaluating multiple attrs is not ideal, but fixing it is pretty easy.
flake.nix
@ -15,0 +25,4 @@
"aarch64-linux"
];
forAllSystems = func:
jade commented 2025-06-18 02:16:54 +00:00
Owner
Copy link

it doesn't matter that much here but we probably should use a pattern that doesn't reevaluate nixpkgs for every usage. what i would advise is genAttrs outside this function to make an attrset pkgsFor, which you then access the pkgs for the system in. this means that you memoize the nixpkgs import. then this function is just f: mapAttrs (system: pkgs: f pkgs) pkgsFor

it doesn't matter *that* much here but we probably should use a pattern that doesn't reevaluate nixpkgs for every usage. what i would advise is genAttrs *outside* this function to make an attrset `pkgsFor`, which you then access the pkgs for the system in. this means that you memoize the nixpkgs import. then this function is just `f: mapAttrs (system: pkgs: f pkgs) pkgsFor`
flake.nix
@ -15,3 +38,4 @@
in
{
inherit inputs;
pkgs = forAllSystems (pkgs: pkgs);
jade commented 2025-06-18 02:10:11 +00:00
Owner
Copy link

that doesn't look right oh, okay, it's just funny looking. i guess you could use nixpkgs.lib.id here, but shrug.

~~that doesn't look right~~ oh, okay, it's just funny looking. i guess you could use nixpkgs.lib.id here, but shrug.
This pull request has changes conflicting with the target branch.
  • flake.nix
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u no-flake-utils:llakala-no-flake-utils
git switch llakala-no-flake-utils

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff llakala-no-flake-utils
git switch llakala-no-flake-utils
git rebase main
git switch main
git merge --ff-only llakala-no-flake-utils
git switch llakala-no-flake-utils
git rebase main
git switch main
git merge --no-ff llakala-no-flake-utils
git switch main
git merge --squash llakala-no-flake-utils
git switch main
git merge --ff-only llakala-no-flake-utils
git switch main
git merge llakala-no-flake-utils
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
jade
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lix-project/nixos-module#70
No description provided.
Delete branch "llakala/nixos-module:no-flake-utils"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?