lix-project/nix-eval-jobs
2
1
Fork 4
Code Issues 1 Pull requests 2 Packages Projects Releases Wiki Activity

Fix compilation for latest Lix main #19

Merged
jade merged 1 commit from jade/fix-compilation into main 2024-12-06 21:54:13 +00:00
Conversation 0 Commits 1 Files changed 5 +38 -35
jade commented 2024-12-06 21:17:28 +00:00
Owner
Copy link

Supercedes #18

Supercedes https://git.lix.systems/lix-project/nix-eval-jobs/pulls/18
jade added 1 commit 2024-12-06 21:17:32 +00:00
jade requested review from pennae 2024-12-06 21:17:37 +00:00
pennae requested changes 2024-12-06 21:26:13 +00:00
Dismissed
pennae left a comment
Owner
Copy link

this'll work, but it can be made just a little bit more robust

this'll work, but it can be made just a little bit more robust
src/worker.cc Outdated
@ -44,2 +45,3 @@
static nix::Value *releaseExprTopLevelValue(nix::EvalState &state,
static nix::Value *releaseExprTopLevelValue(nix::Evaluator &evaluator,
nix::EvalState &state,
pennae commented 2024-12-06 21:24:55 +00:00
Owner
Copy link

&state.ctx != &evaluator is unsound, so if you need both you should take the evaluator from the state

`&state.ctx != &evaluator` is unsound, so if you need both you should take the evaluator from the state
jade marked this conversation as resolved
jade force-pushed jade/fix-compilation from 8c5bbf8dde to bdbe3e1304 2024-12-06 21:51:04 +00:00 Compare
pennae approved these changes 2024-12-06 21:53:52 +00:00
jade merged commit df3edf3730 into main 2024-12-06 21:54:13 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
pennae
Labels
Clear labels   
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lix-project/nix-eval-jobs#19
No description provided.
Delete branch "jade/fix-compilation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?