Fix GitHub API to use the API versioning information correctly #255
Labels
No labels
Area/build-packaging
Area/cli
Area/evaluator
Area/flakes
Area/language
Area/profiles
Area/protocol
Area/releng
Area/remote-builds
Area/repl
Area/store
bug
Cross Compilation
devx
docs
Downstream Dependents
E/easy
E/hard
E/help wanted
E/reproducible
E/requires rearchitecture
imported
Needs Langver
OS/Linux
OS/macOS
performance
regression
release-blocker
RFD
stability
Status
blocked
Status
invalid
Status
postponed
Status
wontfix
testing
testing/flakey
ux
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: lix-project/lix#255
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
in
src/libfetchers/github.cc
we do not specify the github api version. this is sorta busted but also it will just default to 2022-11-28 if not specified. it would be very easy to fix though. see:https://docs.github.com/en/rest/about-the-rest-api/api-versions?apiVersion=2022-11-28
the thing that's weird is that we ask for api v3 on on-prem instances and don't specify for cloud github.com.
From what I understand, the
v3
in the URL for on-prem instances is an old versioning for the REST API that is still leaking through, and not related to the currently used date-based API versioning scheme (2022-11-28
).So the version header should be added for both on-prem and cloud, and the
v3
is just a fixed part of the URL for on-prem.i think Artemis(not t) is working on this, based on fedi posts. just fyi if anyone else is looking into picking it up.