upgrade-nix fails to install instanced nix-daemon@.service #1112
Labels
No labels
Affects/CppNix
Affects/Nightly
Affects/Only nightly
Affects/Stable
Area/build-packaging
Area/cli
Area/evaluator
Area/fetching
Area/flakes
Area/language
Area/lix ci
Area/nix-eval-jobs
Area/profiles
Area/protocol
Area/releng
Area/remote-builds
Area/repl
Area/repl/debugger
Area/store
awaiting
author
awaiting
contributors
bug
Context
contributors
Context
drive-by
Context
maintainers
Context
RFD
crash 💥
Cross Compilation
devx
docs
Downstream Dependents
E/easy
E/hard
E/help wanted
E/reproducible
E/requires rearchitecture
Feature/S3
Importance
High
Importance
Low
imported
Language/Bash
Language/C++
Language/NixLang
Language/Python
Language/Rust
Needs Langver
OS/Linux
OS/macOS
performance
regression
Release Blocking
Non-urgent
Release Blocking
Urgent
stability
Status
blocked
Status
invalid
Status
postponed
Status
wontfix
testing
testing/flakey
Topic/Large Scale Installations
Urgency
High
Urgency
Low
ux
No project
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
lix-project/lix#1112
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Describe the bug
When you upgrade to a nightly Lix from an existing non-NixOS install, the new instanced systemd target does not get linked in. As a result, daemon socket activation stops working correctly, as the socket unit file has
Accept=Yeswhich causes systemd to expect thSteps To Reproduce
curl -sSf -L https://install.lix.systems/lix | sh -s -- install)56988d8605) and capture the store path.sudo nix upgrade-nix --store-path $builtStorePath.nix store pingno longer works when using the daemon.Expected behavior
Either it should upgrade correctly or some kind of error should be thrown indicating a manual step is required for this update.
nix --versionoutputUpgradtoupgrade-nixfails to install instancednix-daemon@systemd unittoupgrade-nixfails to install instancednix-daemon@systemd unitupgrade-nixfails to install instancednix-daemon@.servicetbh
upgrade-nixshould just be deleted. on a nixos system it has no purpose, and on non-nixos systems it is bound to always cause problems of this sort. the installer has much better knowledge of where to put what and how to activate it, upgrading an installation should be done via the installer as well to take advantage of thatI totally agree but right now this is our supported flow until that work gets done and either we need to block release on the installer improvements or (more realistically) block release on adding special case handling to upgrade-nix (I imagine we could add some kind of script that gets run after the profile is built but before switching to it if we wanted to make it somewhat generic)
yes, the releaswe cannot happen before we have some solution to this. we would greatly prefer doing this in the installer if at all possible because having two (diverging?) methods to get the latest version is likely to cause ever more problems as time passes, but we're not familiar with how active installer maintenance is right now
it seems that the most reasonable thing we can do is to refuse to upgrade with an additional confirmation step if
systemctlis present andnix-daemon.socketis enabled without anix-daemon@.socketbeing present. that should be easy enough to add and can link to our upgrade documentation to explain the gory details@pennae wrote in #1112 (comment):
This is what we should go with, for now. Eventually (next release, prolly?) we'll have the installer set up a basic profile manager to handle system upgrades, and then we can tear out
upgrade-nix.also, just to keep the record consistent:
We decided the installer doesn't; and instead a profile management tool is the actual thing that should be handling this.