Merge changes I4bffa766,If2561cd5 into main

* changes:
  add and fix -Wignored-qualifiers
  add and fix -Wdeprecated-copy
This commit is contained in:
Qyriad 2024-05-09 17:52:11 +00:00 committed by Gerrit Code Review
commit 9ae90612a7
4 changed files with 7 additions and 1 deletions

View file

@ -405,6 +405,8 @@ add_project_arguments(
'-Wimplicit-fallthrough', '-Wimplicit-fallthrough',
'-Werror=switch', '-Werror=switch',
'-Werror=switch-enum', '-Werror=switch-enum',
'-Wdeprecated-copy',
'-Wignored-qualifiers',
# Enable assertions in libstdc++ by default. Harmless on libc++. Benchmarked # Enable assertions in libstdc++ by default. Harmless on libc++. Benchmarked
# at ~1% overhead in `nix search`. # at ~1% overhead in `nix search`.
# #

View file

@ -186,7 +186,7 @@ struct CurlInputScheme : InputScheme
virtual const std::string inputType() const = 0; virtual const std::string inputType() const = 0;
const std::set<std::string> transportUrlSchemes = {"file", "http", "https"}; const std::set<std::string> transportUrlSchemes = {"file", "http", "https"};
const bool hasTarballExtension(std::string_view path) const bool hasTarballExtension(std::string_view path) const
{ {
return path.ends_with(".zip") || path.ends_with(".tar") return path.ends_with(".zip") || path.ends_with(".tar")
|| path.ends_with(".tgz") || path.ends_with(".tar.gz") || path.ends_with(".tgz") || path.ends_with(".tar.gz")

View file

@ -185,6 +185,8 @@ public:
HintFmt(const HintFmt & hf) : fmt(hf.fmt) {} HintFmt(const HintFmt & hf) : fmt(hf.fmt) {}
HintFmt & operator=(HintFmt const & rhs) = default;
std::string str() const std::string str() const
{ {
return fmt.str(); return fmt.str();

View file

@ -77,6 +77,8 @@ public:
return ref<T2>((std::shared_ptr<T2>) p); return ref<T2>((std::shared_ptr<T2>) p);
} }
ref<T> & operator=(ref<T> const & rhs) = default;
bool operator == (const ref<T> & other) const bool operator == (const ref<T> & other) const
{ {
return p == other.p; return p == other.p;