diff --git a/meson.build b/meson.build index 6231175e6..5885905c5 100644 --- a/meson.build +++ b/meson.build @@ -405,6 +405,8 @@ add_project_arguments( '-Wimplicit-fallthrough', '-Werror=switch', '-Werror=switch-enum', + '-Wdeprecated-copy', + '-Wignored-qualifiers', # Enable assertions in libstdc++ by default. Harmless on libc++. Benchmarked # at ~1% overhead in `nix search`. # diff --git a/src/libfetchers/tarball.cc b/src/libfetchers/tarball.cc index 68cb0ca40..cda6b7acb 100644 --- a/src/libfetchers/tarball.cc +++ b/src/libfetchers/tarball.cc @@ -186,7 +186,7 @@ struct CurlInputScheme : InputScheme virtual const std::string inputType() const = 0; const std::set transportUrlSchemes = {"file", "http", "https"}; - const bool hasTarballExtension(std::string_view path) const + bool hasTarballExtension(std::string_view path) const { return path.ends_with(".zip") || path.ends_with(".tar") || path.ends_with(".tgz") || path.ends_with(".tar.gz") diff --git a/src/libutil/fmt.hh b/src/libutil/fmt.hh index aa7c6926a..df4492993 100644 --- a/src/libutil/fmt.hh +++ b/src/libutil/fmt.hh @@ -185,6 +185,8 @@ public: HintFmt(const HintFmt & hf) : fmt(hf.fmt) {} + HintFmt & operator=(HintFmt const & rhs) = default; + std::string str() const { return fmt.str(); diff --git a/src/libutil/ref.hh b/src/libutil/ref.hh index 5d0c3696d..03aa64273 100644 --- a/src/libutil/ref.hh +++ b/src/libutil/ref.hh @@ -77,6 +77,8 @@ public: return ref((std::shared_ptr) p); } + ref & operator=(ref const & rhs) = default; + bool operator == (const ref & other) const { return p == other.p;