Rebase on top of detsys-ts for abstracting over install.determinate.systems #74
No reviewers
Labels
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: lix-project/lix-install-action#74
Loading…
Reference in a new issue
No description provided.
Delete branch "detsys-ts"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Description
Checklist
@ -1089,28 +1021,20 @@ function action_input_bool(name: string): boolean {
return actions_core.getBooleanInput(name);
It looks like this is "finally"-ish enough to fire in case anything during install crashes, but maybe even just move it down to 1049, in an explicit
finally
?seems like getUniqueId already appears a randomUUID...
@ -17,2 +17,4 @@
- run: nix develop --command pnpm install
- run: nix develop --command pnpm run all
- run: git status --porcelain=v1
- run: test $(git status --porcelain=v1 2>/dev/null | wc -l) -eq 0
not sure if this applies to pnpm, but do you want/need some equivalent of
--no-save
? Seems like maybe that was just to avoid dirtying the tree mid-run?I realize these are renames of existing functionality, but it seems like
source-url
more or less can encompass all of these usages - preusmably you can "just" use a URL that points to the branch/pr/rev/tag?@ -12,3 +13,4 @@
"all": "pnpm run format && pnpm run lint && pnpm run build && pnpm run package"
},
"repository": {
"type": "git",
run prettier too? or does lint check prettier? might be nice either way, if we check prettier on CI, to know locally first (not that I forget and have to push prettier fixup commits...)
@ -1089,28 +1021,20 @@ function action_input_bool(name: string): boolean {
return actions_core.getBooleanInput(name);
I've cleaned this up a lot, by delegating the actual execution of this code as callbacks that the IdsToolbox calls.
@ -17,2 +17,4 @@
- run: nix develop --command pnpm install
- run: nix develop --command pnpm run all
- run: git status --porcelain=v1
- run: test $(git status --porcelain=v1 2>/dev/null | wc -l) -eq 0
We're doing this deliberately actually, to make sure it is clean and not an outdated lockfile.
@ -12,3 +13,4 @@
"all": "pnpm run format && pnpm run lint && pnpm run build && pnpm run package"
},
"repository": {
"type": "git",
format
does that :)We could, but I've seen time and time again folks (internal & external) mess up the structure, so I think having these sorts of helpers makes it a nicer experience for testing PRs and whatnot.