lix-project/lix-install-action
1
0
Fork 0
Code Issues 11 Pull requests Actions Packages Projects Releases Wiki Activity

DETERMINATE_NIX_KVM fixup, support Magic Nix Cache + FlakeHub Cache on Namespace runners #72

Merged
grahamc merged 16 commits from mnc into main 2024-03-11 23:53:26 +00:00
Conversation 0 Commits 16 Files changed 5 +40 -10
grahamc commented 2024-03-11 15:29:54 +00:00 (Migrated from github.com)
Copy link
Description

This PR fixes a glitch where we'd hilariously (...) set DETERMINATE_NIX_KVM to 0 or 1 depending on if KVM was available, and then immediately reset it to 0. Oops.

It also improves the ARC and Namespace support by bind-mounting more of the host into the process supervisor container, so post-build-hooks can function -- like the FlakeHub Cache runner. Further, it joins the nix-daemon's process into the host so the GitHub Actions Cache support works as expected.

Checklist
  • Tested changes against a test repository
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • (If this PR is for a release) Updated README to point to the new tag (leave unchecked if not applicable)
##### Description This PR fixes a glitch where we'd hilariously (...) set DETERMINATE_NIX_KVM to 0 or 1 depending on if KVM was available, and then immediately reset it to 0. Oops. It also improves the ARC and Namespace support by bind-mounting more of the host into the process supervisor container, so post-build-hooks can function -- like the FlakeHub Cache runner. Further, it joins the nix-daemon's process into the host so the GitHub Actions Cache support works as expected. ##### Checklist - [ ] Tested changes against a test repository - [ ] Added or updated relevant documentation (leave unchecked if not applicable) - [ ] (If this PR is for a release) Updated README to point to the new tag (leave unchecked if not applicable)
lucperkins (Migrated from github.com) approved these changes 2024-03-11 20:22:24 +00:00
lucperkins (Migrated from github.com) approved these changes 2024-03-11 20:23:41 +00:00
lucperkins (Migrated from github.com) left a comment
Copy link

Seems fine to me

Seems fine to me
Sign in to join this conversation.
Reviewers
No reviewers
lucperkins
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lix-project/lix-install-action#72
No description provided.
Delete branch "mnc"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?