No longer require sudo #64

Merged

Hoverbear merged 3 commits from hoverbear/fh-156-installer-action-shouldnt-require-sudo into main

2024-01-09 17:50:39 +00:00

Hoverbear commented

2024-01-08 18:50:55 +00:00

(Migrated from github.com)

Description

This should resolve https://github.com/DeterminateSystems/nix-installer-action/issues/62

Checklist

Tested changes against a test repository
Added or updated relevant documentation (leave unchecked if not applicable)
(If this PR is for a release) Updated README to point to the new tag (leave unchecked if not applicable)

##### Description This should resolve https://github.com/DeterminateSystems/nix-installer-action/issues/62 ##### Checklist - [ ] Tested changes against a test repository - [ ] Added or updated relevant documentation (leave unchecked if not applicable) - [ ] (If this PR is for a release) Updated README to point to the new tag (leave unchecked if not applicable)

grahamc (Migrated from github.com) reviewed 2024-01-08 20:12:08 +00:00

src/main.ts

grahamc (Migrated from github.com) commented

2024-01-08 20:12:08 +00:00

Sometimes the root username can be known as toor. How about checking if the uid is 0?

    const is_root = current_user.uid === 0;

Sometimes the root username can be known as `toor`. How about checking if the uid is 0? ```suggestion const is_root = current_user.uid === 0; ```

grahamc (Migrated from github.com) reviewed 2024-01-08 21:25:06 +00:00

src/main.ts

grahamc (Migrated from github.com) commented

2024-01-08 21:25:05 +00:00

Looks like this is inverted, and uses sudo if our euid is 0.

Hoverbear (Migrated from github.com) reviewed 2024-01-08 21:28:20 +00:00

src/main.ts

Hoverbear (Migrated from github.com) commented

2024-01-08 21:28:20 +00:00

Incredible job, Ana.

colemickens (Migrated from github.com) approved these changes 2024-01-09 17:33:33 +00:00

No reviewers

colemickens

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lix-project/lix-install-action#64

No description provided.