Support private flakes on FlakeHub #38
Loading…
Reference in a new issue
No description provided.
Delete branch "flakehub"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Description
Use the GitHub Actions-issued JWT to authenticate with FlakeHub.
The repository will be granted its due permissions on FlakeHub,
and be able to pull the user's private flakes.
Note that private flakes are in a closed beta, and interested users should contact support@flakehub.com to get access.
Checklist
How about a
--netrc
arg on the installer? I don't really want to shell out for this. (I'd prefer this, I think!)Otherwise, I suggest writing this data using
nodejs
's standard library instead of using shell commands, then usingsudo
to move the file. Here's an example of writing a binary out from this repo:3ebd1aebb4/src/main.ts (L363-L401)
Alternatively, we can rig up a way for this to call a specific function as root to do this without shelling out.
If we choose a method that does not include a
--netrc
arg onnix-installer
, we will also need to make a check to pick up anyextra-conf
setnetrc
and either error or use that.We chatted on Discord and decided it'd be better to write out a separate netrc and pass in a netrc-file option.
Add newline at the end (I need to change
fh init
to do that)Thanks @lucperkins, pushed all those edits!
This will falsely flag if the user has
netrc-file
anywhere in their config, even at the end of a line. Could we use a regex to ensure it's start of the line?Rest looks good, just one nit.
Ohp, that's great idea! Yes.
fixed!
Sometimes silly looking things make it into production. For example: Most of the code I write. :)
🤭