lix-project/hydra
3
0
Fork 6
Code Issues 2 Pull requests Packages Projects Releases Wiki Activity

Add gitea push hook #6

Merged
delroth merged 3 commits from snaakey/hydra:main into main 2024-08-26 18:47:40 +00:00
Conversation 4 Commits 3 Files changed 4 +39 -7
snaakey commented 2024-08-22 18:21:46 +00:00
Contributor
Copy link
- fix github webhook - Merge from Mainline https://github.com/NixOS/hydra/pull/1227
snaakey added 1 commit 2024-08-22 18:21:50 +00:00 
Add gitea push hook
snaakey added 1 commit 2024-08-25 11:53:53 +00:00
snaakey force-pushed main from 46c68b3a69 to e5b24be49b 2024-08-25 12:10:49 +00:00 Compare
snaakey force-pushed main from e5b24be49b to 3c5c42385a 2024-08-25 12:16:14 +00:00 Compare
delroth commented 2024-08-26 17:00:55 +00:00
Member
Copy link

Could you cherry-pick the individual commits from the author, instead of what you've done currently which squashes everything (and loses proper commit attribution) into one merge commit?

Otherwise no objection from me to merge this, I don't use this and can't test it, but I could believe it works. Long term we should figure out whether we want to continue supporting this or not...

Could you cherry-pick the individual commits from the author, instead of what you've done currently which squashes everything (and loses proper commit attribution) into one merge commit? Otherwise no objection from me to merge this, I don't use this and can't test it, but I could believe it works. Long term we should figure out whether we want to continue supporting this or not...
snaakey force-pushed main from 3c5c42385a to 3e7b407bfe 2024-08-26 18:23:59 +00:00 Compare
snaakey force-pushed main from 3e7b407bfe to ab6d81fad4 2024-08-26 18:27:18 +00:00 Compare
snaakey commented 2024-08-26 18:32:54 +00:00
Author
Contributor
Copy link

Cherry-picked the original commits and tested it.

Cherry-picked the original commits and tested it.
delroth commented 2024-08-26 18:46:49 +00:00
Member
Copy link

I'll merge this for now but oh gods this is a complete misfeature and a blatant DoS hole without signature checking. The only reason I'm not NAK-ing it is because there's an even worse DoS hole via /api/push which is also unauth'd, GET, and uses a bespoke scheme that does not support signatures.

I'll merge this for now but oh gods this is a complete misfeature and a blatant DoS hole without signature checking. The only reason I'm not NAK-ing it is because there's an even worse DoS hole via /api/push which is also unauth'd, GET, and uses a bespoke scheme that does not support signatures.
delroth merged commit ab6d81fad4 into main 2024-08-26 18:47:40 +00:00
snaakey commented 2024-08-26 18:57:01 +00:00
Author
Contributor
Copy link

average perl project

average perl project
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lix-project/hydra#6
No description provided.
Delete branch "snaakey/hydra:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?