lix-project/hydra
4
2
Fork 8
Code Issues 5 Pull requests 2 Projects Releases Packages Wiki Activity

lix compat: SSH connections uses socketpairs now #51

Merged
ma27 merged 1 commit from raito/hydra:socketpairs-ssh into main 2025-06-19 09:20:31 +00:00
Conversation 2 Commits 1 Files changed 2 +25 -25
raito commented 2025-06-14 12:04:05 +00:00
Owner
Copy link

Pipes are removed and replaced by socketpairs the same way Lix does for
ssh-ng.

Fixes #50 but I'm not sure the code is perfectly correct, thorough testing is advised.

Signed-off-by: Raito Bezarius raito@lix.systems

Pipes are removed and replaced by socketpairs the same way Lix does for ssh-ng. Fixes #50 but I'm not sure the code is perfectly correct, thorough testing is advised. Signed-off-by: Raito Bezarius <raito@lix.systems>
Pipes are removed and replaced by socketpairs the same way Lix does for
ssh-ng.

Signed-off-by: Raito Bezarius <raito@lix.systems>
raito reviewed 2025-06-14 12:05:27 +00:00
src/hydra-queue-runner/build-remote.cc
@ -87,1 +91,4 @@
parent.close();
if (dup2(child.get(), STDIN_FILENO) == -1)
throw SysError("cannot dup input pipe to stdin");
raito commented 2025-06-14 12:05:27 +00:00
Author
Owner
Copy link

these should be changed

these should be changed
ma27 commented 2025-06-15 08:59:03 +00:00
Member
Copy link

I don't follow, wdym with "changed"?

I don't follow, wdym with "changed"?
raito commented 2025-06-16 20:35:59 +00:00
Author
Owner
Copy link

"cannot dup input pipe to stdin" should be "cannot dup socket to stdin"

"cannot dup input pipe to stdin" should be "cannot dup socket to stdin"
ma27 approved these changes 2025-06-19 09:20:24 +00:00
ma27 left a comment
Member
Copy link

Will fix up the error message on main (I cannot push to other contributor's branches here, apparently).

Tested on my own Hydra.

Will fix up the error message on main (I cannot push to other contributor's branches here, apparently). Tested on my own Hydra.
ma27 merged commit ba0fb1063b into main 2025-06-19 09:20:31 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
ma27
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lix-project/hydra#51
No description provided.
Delete branch "raito/hydra:socketpairs-ssh"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?