lix-project/hydra
4
2
Fork 8
Code Issues 5 Pull requests 2 Projects Releases Packages Wiki Activity

Bring back constituents #28

Merged
ma27 merged 1 commit from ma27/hydra:bring-back-constituents into main 2025-03-14 11:51:57 +00:00
Conversation 1 Commits 1 Files changed 6 +183
ma27 commented 2025-03-12 09:17:47 +00:00
Member
Copy link

Depends on #25.
Closes #11.

Depends on #25. Closes #11.
The vast majority of changes was pretty straight-forward: we need an
AsyncIoRoot per thread to resolve promises we get from Lix. The `aio`
object is created per thread and passed as lvalue ref instead of making
it a field of the State struct since that struct is shared between the
threads.

The biggest change affects the NAR extractor: parseAndCopyDump has been
removed, instead the `nar::parse` and `nar::dump` parts are public now.
This won't work with the original parse visitor anymore, so instead the
NAR is parsed once and dumped again to copy it to the binary cache. In
between, the generator is walked through to search for relevant files
(such as build products) and after that the generators are recreated for
`AsyncGeneratorInputStream` to read again.
This partially reverts commit 370a4bf138.
ma27 force-pushed bring-back-constituents from 45f1286578 to b89d9b5f50 2025-03-12 12:28:51 +00:00 Compare
ma27 force-pushed bring-back-constituents from b89d9b5f50 to a851cb8a18 2025-03-12 12:36:56 +00:00 Compare
ma27 changed title from WIP: Bring back constituents to Bring back constituents 2025-03-12 12:37:06 +00:00
requested review from raito 2025-03-12 12:37:12 +00:00
raito approved these changes 2025-03-14 00:15:55 +00:00
ma27 merged commit 1e63e0a6d2 into main 2025-03-14 11:51:57 +00:00
ma27 deleted branch bring-back-constituents 2025-03-14 11:51:58 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
raito
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lix-project/hydra#28
No description provided.
Delete branch "ma27/hydra:bring-back-constituents"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?