lix-project/buildbot-nix
15
0
Fork 0
Code Issues 12 Pull requests 6 Packages Projects Releases Wiki Activity

fix(reporters): restore old behavior for Gerrit reporting #27

Merged
jade merged 3 commits from bring-back-old-gerrit-reporting into forkos 2024-10-18 23:41:11 +00:00
Conversation 1 Commits 3 Files changed 5 +109 -52
raito commented 2024-10-12 10:14:38 +00:00
Owner
Copy link

This is an attempt to restore the old formatting, e.g. with failed
checks and a link to the URI.

At the same time, this attempts to fix the eager +1 Verified tag which
is sent when nix-eval is started (?) and not done or when the evaluation
is done instead of the whole nix-eval job seen as completed.

Signed-off-by: Raito Bezarius raito@lix.systems

This is an attempt to restore the old formatting, e.g. with failed checks and a link to the URI. At the same time, this attempts to fix the eager +1 Verified tag which is sent when nix-eval is started (?) and not done or when the evaluation is done instead of the whole nix-eval job seen as completed. Signed-off-by: Raito Bezarius <raito@lix.systems>
raito added 1 commit 2024-10-12 10:14:42 +00:00 
This is an attempt to restore the old formatting, e.g. with failed
checks and a link to the URI.

At the same time, this attempts to fix the eager +1 Verified tag which
is sent when nix-eval is started (?) and not done or when the evaluation
is done instead of the whole nix-eval job seen as completed.

Signed-off-by: Raito Bezarius <raito@lix.systems>
raito force-pushed bring-back-old-gerrit-reporting from d12bca569b to 781bdc51b6 2024-10-12 10:26:18 +00:00 Compare
raito force-pushed bring-back-old-gerrit-reporting from 781bdc51b6 to 9d7a2e71ac 2024-10-13 15:34:00 +00:00 Compare
raito force-pushed bring-back-old-gerrit-reporting from 9d7a2e71ac to 0c5f470fed 2024-10-13 15:38:57 +00:00 Compare
raito added 1 commit 2024-10-13 16:01:40 +00:00 
Let's try to use the reverse proxy rather than Buildbot for that.

Signed-off-by: Raito Bezarius <raito@lix.systems>
raito force-pushed bring-back-old-gerrit-reporting from 86f4652b38 to 894ef835c3 2024-10-13 16:03:22 +00:00 Compare
raito force-pushed bring-back-old-gerrit-reporting from 894ef835c3 to b90a39bd94 2024-10-13 16:12:20 +00:00 Compare
raito force-pushed bring-back-old-gerrit-reporting from b90a39bd94 to e663e034bd 2024-10-13 16:18:06 +00:00 Compare
raito force-pushed bring-back-old-gerrit-reporting from e663e034bd to 1dd0590ca1 2024-10-13 16:24:59 +00:00 Compare
raito force-pushed bring-back-old-gerrit-reporting from 1dd0590ca1 to 5d39634f62 2024-10-13 16:28:57 +00:00 Compare
raito force-pushed bring-back-old-gerrit-reporting from 5d39634f62 to b739fb4c29 2024-10-13 16:32:23 +00:00 Compare
raito added 1 commit 2024-10-13 16:35:44 +00:00 
Signed-off-by: Raito Bezarius <raito@lix.systems>
raito added 1 commit 2024-10-13 16:42:02 +00:00
raito force-pushed bring-back-old-gerrit-reporting from 3dca25ce86 to 183c6ae710 2024-10-13 16:44:11 +00:00 Compare
raito force-pushed bring-back-old-gerrit-reporting from 183c6ae710 to 879e9cdcdf 2024-10-13 16:46:47 +00:00 Compare
raito commented 2024-10-13 19:51:12 +00:00
Author
Owner
Copy link

First commit is useless because it was partially reverted in the second due to global prefix conflicts (buildbot-with-plugins & buildbot propagating the same inputs).

First commit is useless because it was partially reverted in the second due to global prefix conflicts (buildbot-with-plugins & buildbot propagating the same inputs).
jade approved these changes 2024-10-14 04:47:18 +00:00
jade left a comment
Owner
Copy link

lgtm generally, i think we should merge this since it is what is currently running in prod and it doesn't look broken.

lgtm generally, i think we should merge this since it is what is currently running in prod and it doesn't look broken.
buildbot_nix/__init__.py
@ -1029,3 +1034,2 @@
# gerritReviewCB / self.url
BuildStatusGenerator(
message_formatter=MessageFormatterFunction(
mode='all',
jade commented 2024-10-14 04:46:14 +00:00
Owner
Copy link

i wonder if this is the cause of the excessive emails: previously we were only being called when all the builds have finished (either failure or success), right?

i wonder if this is the cause of the excessive emails: previously we were only being called when all the builds have finished (either failure or success), right?
jade commented 2024-10-18 23:40:56 +00:00
Owner
Copy link

hm, no, this doesn't seem to be the cause of that, and there seem to be reasonable numbers of emails so far? let's merge it.

hm, no, this doesn't seem to be the cause of that, and there seem to be reasonable numbers of emails so far? let's merge it.
jade marked this conversation as resolved
jade merged commit 1aa37c4b80 into forkos 2024-10-18 23:41:11 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jade
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lix-project/buildbot-nix#27
No description provided.
Delete branch "bring-back-old-gerrit-reporting"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?