feat: enable per-worker local store slots #24

raito · 2024-10-05T19:01:16Z

raito commented

2024-10-05 19:01:16 +00:00

This is reinventing badly the Nix remote building scheduling protocol. We don't have the choice as we are trying to pass --store which forces us to know which target we are looking at.

This is reinventing badly the Nix remote building scheduling protocol. We don't have the choice as we are trying to pass `--store` which forces us to know which target we are looking at.

raito added 20 commits

2024-10-05 19:01:19 +00:00

feat(debug): add manhole debugging fa83000f07

Signed-off-by: Raito Bezarius <raito@lix.systems>

chore(gerrit): offer projects configuration and factor out private SSH keys d23c41bac0

Previously, we needed to hardcode the URL for private SSH keys,
this is cleaned up and we can iterate over each project for its
configuration.

Configuration is at deployment time.

Signed-off-by: Raito Bezarius <raito@lix.systems>

fix(sshkey): PosixPath does not play well with Buildbot APIs c8ceddc6c6

It expected a `str`, not a `PosixPath`.

Signed-off-by: Raito Bezarius <raito@lix.systems>

fix(gerrit): repourl was not formatted f6f4e043a5

Signed-off-by: Raito Bezarius <raito@lix.systems>

fix(gerrit): pass properly the ssh private key and not its path 135f6a660b

Signed-off-by: Raito Bezarius <raito@lix.systems>

fix(properties): use getProperty 464e02c4ba

Signed-off-by: Raito Bezarius <raito@lix.systems>

fix(eval): event.refUpdate.project instead of event.project d624e412de

Signed-off-by: Raito Bezarius <raito@lix.systems>

feat(eval): in case of total failure, do not derivation show 6bcca27c70

Signed-off-by: Raito Bezarius <raito@lix.systems>

fix(eval): event.change.project is also a buildprop for project name 78ddc0b3e5

Signed-off-by: Raito Bezarius <raito@lix.systems>

feat: support non-flake entrypoint 199aa5ce0c

The way to use Buildbot jobs without Flakes is via `.ci/buildbot.nix`.

Signed-off-by: Raito Bezarius <raito@lix.systems>

fix(log): add the stdio log if it doesn't exist e3399e5d3b

Signed-off-by: Raito Bezarius <raito@lix.systems>

feat(nix-configure): name it 1ee2a6a266

Signed-off-by: Raito Bezarius <raito@lix.systems>

fix(workdir): rebase in build/ for ShellMixin 996b932b21

Signed-off-by: Raito Bezarius <raito@lix.systems>

fix(steps): add *steps* not *step* 8731d0db99

Signed-off-by: Raito Bezarius <raito@lix.systems>

fix(ret): return success and write \n 64372b3dcc

Signed-off-by: Raito Bezarius <raito@lix.systems>

fix(buildbot-name): nix_configure → determining jobs 8965db4111

Signed-off-by: Raito Bezarius <raito@lix.systems>

fix(args): pass the right string 3cb7989561

Signed-off-by: Raito Bezarius <raito@lix.systems>

fix(build): use per-worker slot store 8048398941

Signed-off-by: Raito Bezarius <raito@lix.systems>

fix error: builtins.TypeError: object of type 'int' has no len() b9ed6467b7

randomly pick a builder and pass it as --store 9694451ef4

raito added a new dependency

2024-10-05 19:02:56 +00:00

#23 feat: non-flakes entrypoint

jade reviewed

2024-10-05 19:31:29 +00:00

buildbot_nix/__init__.py

					
				@ -581,0 +698,4 @@

				                "--store",

				                build_store,

				                "--eval-store",

				                "ssh-ng://localhost",

does this require trusted user on localhost? or wait, are we doing this to prevent needing trusted user while still doing remote builds? am confuse

no, it doesn't anymore!

(and yes, that's correct, that's untrusted remote building!)

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin local-stores:local-stores

git switch local-stores

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main

git merge --no-ff local-stores

git switch local-stores

git rebase main

git switch main

git merge --ff-only local-stores

git switch local-stores

git rebase main

git switch main

git merge --no-ff local-stores

git switch main

git merge --squash local-stores

git switch main

git merge --ff-only local-stores

git switch main

git merge local-stores

git push origin main

Sign in to join this conversation.

No reviewers

No labels

No milestone

No project

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Depends on

#23 feat: non-flakes entrypoint

lix-project/buildbot-nix

Reference

lix-project/buildbot-nix!24

Rows
Columns