lix-project/buildbot-nix
15
0
Fork 0
Code Issues 13 Pull requests 7 Projects Releases Packages Wiki Activity

feat: prepare for non-flakes entrypoint #22

Open
raito wants to merge 9 commits from prepare-for-non-flakes into main
pull from: prepare-for-non-flakes
merge into: lix-project:main
Conversation 0 Commits 9 Files changed 2 +71 -37
raito commented 2024-10-05 18:55:44 +00:00
Owner
Copy link

This is a list of all fixups we made for ForkOS in preparations for non-flakes entrypoint.

This is a list of all fixups we made for ForkOS in preparations for non-flakes entrypoint.
raito added 9 commits 2024-10-05 18:55:48 +00:00 
Signed-off-by: Raito Bezarius <raito@lix.systems>
Previously, we needed to hardcode the URL for private SSH keys,
this is cleaned up and we can iterate over each project for its
configuration.

Configuration is at deployment time.

Signed-off-by: Raito Bezarius <raito@lix.systems>
It expected a `str`, not a `PosixPath`.

Signed-off-by: Raito Bezarius <raito@lix.systems>
Signed-off-by: Raito Bezarius <raito@lix.systems>
Signed-off-by: Raito Bezarius <raito@lix.systems>
Signed-off-by: Raito Bezarius <raito@lix.systems>
Signed-off-by: Raito Bezarius <raito@lix.systems>
Signed-off-by: Raito Bezarius <raito@lix.systems>
Signed-off-by: Raito Bezarius <raito@lix.systems>
raito added a new dependency 2024-10-05 18:59:24 +00:00
#23 feat: non-flakes entrypoint
jade reviewed 2024-10-05 19:26:27 +00:00
buildbot_nix/__init__.py
@ -182,3 +182,2 @@
attr = job.get("attr", "eval-error")
name = attr
name = f"{FLAKE_TARGET_ATTRIBUTE_FOR_JOBS}.{name}"
name = f"buildbotJobs.{attr}"
jade commented 2024-10-05 19:25:10 +00:00
Owner
Copy link

uhhhhhhhhhhhhhhhhhhhhhhhhhh this is a regression, no?

uhhhhhhhhhhhhhhhhhhhhhhhhhh this is a regression, no?
raito commented 2024-10-05 21:03:26 +00:00
Author
Owner
Copy link

yes, this won't work on our lix stuff, I can fix it back for backward compat

yes, this won't work on our lix stuff, I can fix it back for backward compat
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin prepare-for-non-flakes:prepare-for-non-flakes
git checkout prepare-for-non-flakes

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout main
git merge --no-ff prepare-for-non-flakes
git checkout prepare-for-non-flakes
git rebase main
git checkout main
git merge --ff-only prepare-for-non-flakes
git checkout prepare-for-non-flakes
git rebase main
git checkout main
git merge --no-ff prepare-for-non-flakes
git checkout main
git merge --squash prepare-for-non-flakes
git checkout main
git merge --ff-only prepare-for-non-flakes
git checkout main
git merge prepare-for-non-flakes
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks
#23 feat: non-flakes entrypoint}
lix-project/buildbot-nix
Reference: lix-project/buildbot-nix#22
No description provided.
Delete branch "prepare-for-non-flakes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?