feat: show package maintainers that are going to be pinged #424

2024-12-05T17:30:27Z

erictapen commented

2024-12-05 17:30:27 +00:00

(Migrated from github.com)

Closes #416

Closes #416 ![tmp LV8YRVXq6l](https://github.com/user-attachments/assets/b211af56-7b12-4db1-b2fd-9f71fd046bd6)

fricklerhandwerk (Migrated from github.com) reviewed

2024-12-06 00:11:54 +00:00

src/website/shared/listeners/cache_suggestions.py

fricklerhandwerk (Migrated from github.com) commented

2024-12-06 00:11:54 +00:00

This will also show maintainers for "removed" (filtered-out) derivations. Probably need to adapt update_suggestion() to also filter those out.

This will also show maintainers for "removed" (filtered-out) derivations. Probably need to adapt `update_suggestion()` to also filter those out.

fricklerhandwerk (Migrated from github.com) reviewed

2024-12-06 00:21:21 +00:00

src/website/webview/templates/components/suggestion.html

fricklerhandwerk (Migrated from github.com) commented

2024-12-06 00:21:21 +00:00

          Notify package maintainers: {{ cached_suggestion.maintainers | length }}

Before going full gettext we should just try to avoid any sort of grammar... I know this ugly but among all cosmetics this scales better until we have the time for polishing.

```suggestion Notify package maintainers: {{ cached_suggestion.maintainers | length }} ``` Before going full gettext we should just try to avoid any sort of grammar... I know this ugly but among all cosmetics this scales better until we have the time for polishing.

erictapen commented

2024-12-09 11:29:10 +00:00

(Migrated from github.com)

1sec, it still shows duplicates

erictapen commented

2024-12-09 11:59:46 +00:00

(Migrated from github.com)

Finally, should be ready now.

erictapen (Migrated from github.com) reviewed

2024-12-09 13:31:20 +00:00

pyrightconfig.json

					
				@ -0,0 +1,3 @@

				{

				  "reportAttributeAccessIssue": false

erictapen (Migrated from github.com) commented

2024-12-09 13:31:20 +00:00

So this is a super annoying lint, that produces unusable errors imo.

Everytime I try to use Prefetch with to_attr, I can't use the attr that is assigned to the object, as I otherwise get this type error. So I'd rather just disables it.

So this is a super annoying lint, that produces unusable errors imo. Everytime I try to use `Prefetch` with `to_attr`, I can't use the attr that is assigned to the object, as I otherwise get this type error. So I'd rather just disables it.