feat: add `create_certificate_with_sid` #5

Open

RaitoBezarius wants to merge 1 commit from issuer-computation into main

RaitoBezarius commented

2024-01-04 03:02:25 +00:00

(Migrated from github.com)

Usually, a SID is cumbersome to produce for a certificate, most of the time, we can reuse the leaf's certificate issuer information.

create_certificate now takes a leaf certificate to extract the issuer information from.

Usually, a SID is cumbersome to produce for a certificate, most of the time, we can reuse the leaf's certificate issuer information. `create_certificate` now takes a leaf certificate to extract the issuer information from.

baloo (Migrated from github.com) reviewed

2024-01-04 18:08:48 +00:00

src/sign.rs

baloo (Migrated from github.com) commented

2024-01-04 18:08:48 +00:00

note to self: This could be worth a impl From<&Cert> for cms::cert::IssuerAndSerialNumber

note to self: This could be worth a `impl From<&Cert> for cms::cert::IssuerAndSerialNumber`

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin issuer-computation:issuer-computation

git switch issuer-computation

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main

git merge --no-ff issuer-computation

git switch issuer-computation

git rebase main

git switch main

git merge --ff-only issuer-computation

git switch issuer-computation

git rebase main

git switch main

git merge --no-ff issuer-computation

git switch main

git merge --squash issuer-computation