jade/lix
0
0
Fork 0
forked from lix-project/lix
Code Pull requests Activity
13442 commits 10 branches 3 tags 77 MiB
Commit graph

13442 commits

This branch
This branch
All branches
Author SHA1 Message Date
John Ericson 0afdf4084c Fix #7655 
We had some local variables left over from the older (more
complicated) implementation of this function. They should all be unused,
but one wasn't by mistake.

Delete them all, and replace the one that was still in use as intended.
 2023-01-21 23:55:06 -05:00
John Ericson 88d8f6ac48 Expand tests to reproduce #7655 
The original `builtins.getContext` test from
1d757292d0 would have caught this. The
problem is that b30be6b450 adding
`builtins.appendContext` modified that test to make it test too much at
once, rather than adding a separate test.

We now have isolated tests for both functions, and also a property test
showing everything put together (in the form of an eta rule for strings
with context). This is better coverage and properly reproduces the bug.
 2023-01-21 23:50:09 -05:00
Robert Hensing 04de0dd0b4
Merge pull request #7577 from hercules-ci/pr-template 
.github: Add pull request template
 2023-01-20 14:36:09 +01:00
Robert Hensing dfbdde6d07
Update .github/PULL_REQUEST_TEMPLATE.md 2023-01-20 14:06:46 +01:00
Robert Hensing 7f04a54214
Update .github/PULL_REQUEST_TEMPLATE.md 2023-01-20 13:56:14 +01:00
Valentin Gagarin e90d7570a3
Merge pull request #7647 from fps/operator_doc 
doc: fix update operator description
 2023-01-20 13:54:51 +01:00
Florian Paul Schmidt 4ff9ed5c2d doc: fix update operator description 2023-01-20 13:21:45 +01:00
Théophane Hufschmitt fdc02d2b6a
Merge pull request #7490 from fricklerhandwerk/doc-realise 
define the terms "realise" and "valid" for store paths
 2023-01-20 11:19:45 +01:00
Valentin Gagarin b911307d7a
Merge pull request #7629 from phip1611/patch-3 2023-01-19 16:41:20 +01:00
Philipp Schuster 9469b1bb30 doc: update language/index.md 
- make `<nixpkgs>` visible (was blank in the rendered version)
 2023-01-19 15:11:20 +01:00
Eelco Dolstra 38b90c618f
Merge pull request #7640 from marceltransier/patch-2 
Fix update operator usage in operators.md
 2023-01-19 11:12:10 +01:00
Eelco Dolstra 5a0865b591
Merge pull request #7638 from marceltransier/patch-1 
Fix markdown error in operators.md
 2023-01-19 11:04:52 +01:00
Marcel Transier 8b9325ec4a
Fix update operator usage in operators.md 2023-01-19 10:20:41 +01:00
Marcel Transier 9141b74eb7
Fix markdown error in operators.md 
Escape logical or pipe in markdown table according to https://github.github.com/gfm/#example-200
 2023-01-18 22:34:49 +01:00
Eelco Dolstra 2513eba46a
Merge pull request #7636 from asymmetric/relnotes-flakre-reg 
Relase notes: add empty flake registry
 2023-01-18 18:04:27 +01:00
Lorenzo Manacorda 913782af4d Relase notes: add empty flake registry 
Introduced in #5420
 2023-01-18 17:34:19 +01:00
Eelco Dolstra 0510aa40a3
Merge pull request #7631 from edolstra/output-names 
OutputSpec: Allow all valid output names
 2023-01-18 17:09:15 +01:00
Eelco Dolstra 75c89c3e5e Add test for OutputsSpec::Names 
From @Ericson2314.
 2023-01-18 16:34:37 +01:00
Eelco Dolstra 8a3b30822b Fix indentation 2023-01-18 16:33:39 +01:00
Philipp Schuster 70e193d64b
Update binary-cache-substituter.md (#7628) 
`binary-caches` is deprecated and `substituters` the new recommended option.
 2023-01-18 15:08:20 +00:00
Eelco Dolstra ee1372d246
Merge pull request #7627 from edolstra/fetchTarball-channel 
Restore support for channel: URLs in fetchTarball
 2023-01-18 14:26:35 +01:00
Eelco Dolstra 1ebfa6ba2d Add some tests for illegal output names 2023-01-18 14:21:17 +01:00
Eelco Dolstra 95cfd50d25 OutputSpec: Allow all valid output names 
Fixes #7624.
 2023-01-18 14:14:29 +01:00
Théophane Hufschmitt e3bb97d44a
Merge pull request #7598 from yangsheng6810/fix_env_escape 
Add escape for systemd service in installer script
 2023-01-18 13:46:29 +01:00
Eelco Dolstra 01f268322a Restore support for channel: URLs in fetchTarball 
Fixes #7625.
 2023-01-18 12:57:03 +01:00
Robert Hensing d385c13202
Merge pull request #7621 from hercules-ci/nixpkgs-lib-regression-test 
Revert #6204 to fix regression, add nixpkgs/lib/tests as regression test
 2023-01-18 02:26:30 +01:00
Robert Hensing 620e4fb89b flake.nix: Add nixpkgs/lib/tests as regression test 2023-01-18 01:55:21 +01:00
Robert Hensing 9b33ef3879 Revert "Merge pull request #6204 from layus/coerce-string" 
This reverts commit a75b7ba30f, reversing
changes made to 9af16c5f74.
 2023-01-18 01:34:07 +01:00
Eelco Dolstra 98f57f44bb
Merge pull request #7620 from NixOS/bump-2.14.0 
Bump version
 2023-01-17 22:39:07 +01:00
Eelco Dolstra 2769c83b5e Bump version 2023-01-17 22:08:36 +01:00
Eelco Dolstra ab9dcf3477
Merge pull request #7614 from edolstra/typo 
Fix typo in the release notes
 2023-01-17 17:31:35 +01:00
Eelco Dolstra 3ff9fc0d7d Typo 2023-01-17 17:03:30 +01:00
Eelco Dolstra 94d6bccf4f
Merge pull request #7613 from obsidiansystems/fix-variant-missing-raw 
Try again to fix aarch64-linux build failure
 2023-01-17 16:06:45 +01:00
John Ericson 3965b0f75f Try again to fix aarch64-linux build failure 
f419ab48e6 was on the right track, but
there are a few more missing `raw()` calls to fix.
 2023-01-17 09:14:17 -05:00
Eelco Dolstra deb35c84b3
Merge pull request #7612 from edolstra/release-notes 
Release notes for 2.13
 2023-01-17 13:47:56 +01:00
Eelco Dolstra 9a32f77a95
Merge pull request #7606 from hercules-ci/recognize-some-flake-attributes 
flake check: Recognize well known community attributes
 2023-01-17 13:27:30 +01:00
Eelco Dolstra c1934eb074 Release notes 2023-01-17 13:23:31 +01:00
Robert Hensing 4e7592b593 flake check: Recognize well known community attributes 
This avoids warning fatigue, making `nix flake check` more effective.
 2023-01-16 20:16:45 +01:00
Eelco Dolstra 1df3d62c76
Merge pull request #7585 from NixOS/macos-disconnect 
MonitorFdHup: Make it work on macOS again
 2023-01-16 13:30:15 +01:00
Robert Hensing c133e66375
Merge pull request #7604 from obsidiansystems/fix-variant-missing-raw 
Try to fix build failure
 2023-01-16 12:22:30 +01:00
John Ericson f419ab48e6 Try to fix build failure 
Failure: https://hydra.nixos.org/build/205357257/nixlog/1

The problem seems to be trying to `std::visit` a derived class of
`std::variant`. Per
https://stackoverflow.com/questions/63616709/incomplete-type-stdvariant-used-in-nested-name-specifier
certain C++ standard library implementations allow this, but others do
not.

The solution is simply to call the `raw` method, which upcasts the
reference back to the `std::variant`.
 2023-01-15 15:16:14 -05:00
Robert Hensing 2e41ae9f93
Merge pull request #7599 from obsidiansystems/move-path-info-definitions 
Move `ValidPathInfo` defintions to `path-info.cc`
 2023-01-14 11:54:57 +01:00
Robert Hensing dc9c455979 Apply suggestions from code review 
Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
 2023-01-14 11:24:54 +01:00
John Ericson a416476217 Move ValidPathInfo defintions to path-info.cc 
Originally there was no `path-info.*`, then there was `path-info.hh`,
then there was `path-info.cc`, but only for new things. Moving this
stuff over makes everything consistent.
 2023-01-13 15:39:19 -05:00
Sheng Yang 7c08144c4a Add escape for systemd service in installer script 
Among all the characters that are allowed in a URL, both the percentage
sign "%" and the single quotation mark "'" needs escaping when written
as a environment variable in a systemd service file. While the single
quotation mark may be rare, the percentage sign is widely used to escape
characters in a URL. This is especially common in proxy setting, where
username and password may contain special characters that need
percentage escaping. This patch applies the following replacements:

  % -> %%
  ' -> \'
 2023-01-14 03:46:11 +08:00
Robert Hensing fec527bba1
Merge pull request #7597 from tweag/move-implem-bit-to-implem-file 
Move the `getBuildLog` implementation to its own implementation file
 2023-01-13 20:16:33 +01:00
Robert Hensing d21f54958e
Merge pull request #6815 from obsidiansystems/better-wanted-outputs 
`OutputSpec` for `DerivationGoal` and `DerivedPath`, today's `OutputSpec` -> `ExtendedOutputSpec`
 2023-01-13 16:03:12 +01:00
Théophane Hufschmitt b8a0e9a9b8 Move the getBuildLog implementation to its own implementation file 
Keep the header minimal and clean
 2023-01-13 11:05:44 +01:00
Théophane Hufschmitt bdeb6de889
Merge pull request #7430 from tweag/ca/fix-nix-log 
Ca/fix nix log
 2023-01-13 11:00:56 +01:00
Théophane Hufschmitt dda71d3726
Merge pull request #7427 from fricklerhandwerk/pr-policy 
state priorities in triaging and discussion process
 2023-01-13 10:53:40 +01:00