From b81ec5f11f2cb0bc7886b66a4c89e5d7c24f90e4 Mon Sep 17 00:00:00 2001 From: Ana Hobden Date: Thu, 10 Nov 2022 08:46:31 -0800 Subject: [PATCH] Include warning messages on noops for mac --- src/action/base/create_group.rs | 5 +---- src/action/base/create_user.rs | 2 +- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/src/action/base/create_group.rs b/src/action/base/create_group.rs index 8e60cf9..3e62f96 100644 --- a/src/action/base/create_group.rs +++ b/src/action/base/create_group.rs @@ -70,9 +70,6 @@ impl Action for CreateGroup { patch: _, } | OperatingSystem::Darwin => { - // TODO(@hoverbear): Make this actually work... - // Right now, our test machines do not have a secure token and cannot delete users. - if Command::new("/usr/bin/dscl") .args([".", "-read", &format!("/Groups/{name}")]) .status() @@ -155,7 +152,7 @@ impl Action for CreateGroup { | OperatingSystem::Darwin => { // TODO(@hoverbear): Make this actually work... // Right now, our test machines do not have a secure token and cannot delete users. - + tracing::warn!("Harmonic currently cannot delete groups on Mac due to https://github.com/DeterminateSystems/harmonic/issues/33. This is a no-op, installing with harmonic again will use the existing group."); // execute_command(Command::new("/usr/bin/dscl").args([ // ".", // "-delete", diff --git a/src/action/base/create_user.rs b/src/action/base/create_user.rs index cf1704e..cc4d068 100644 --- a/src/action/base/create_user.rs +++ b/src/action/base/create_user.rs @@ -249,7 +249,7 @@ impl Action for CreateUser { | OperatingSystem::Darwin => { // TODO(@hoverbear): Make this actually work... // Right now, our test machines do not have a secure token and cannot delete users. - + tracing::warn!("Harmonic currently cannot delete groups on Mac due to https://github.com/DeterminateSystems/harmonic/issues/33. This is a no-op, installing with harmonic again will use the existing user."); // execute_command(Command::new("/usr/bin/dscl").args([ // ".", // "-delete",