yshui/lix
0
0
Fork 0
forked from lix-project/lix
Code Pull requests Activity

archive: disable preallocate-contents by default

Browse source 
using fallocate() to preallocate files space does more harm than good:
 - breaks compression on btrfs
 - has been called "not the right thing to do" by xfs developers
(because delayed allocation that most filesystems implement leads to smarter
allocation than what the filesystem needs to do if we upfront fallocate files)
This commit is contained in:
Dominique Martinet 2020-11-26 14:26:57 +01:00
parent 8252a44e96
commit 1fd13d67e8
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/libutil/archive.cc
View file

@ -27,7 +27,7 @@ struct ArchiveSettings : Config
#endif
"use-case-hack",
"Whether to enable a Darwin-specific hack for dealing with file name collisions."};
Setting<bool> preallocateContents{this, true, "preallocate-contents",
Setting<bool> preallocateContents{this, false, "preallocate-contents",
"Whether to preallocate files when writing objects with known size."};
};