vriska/hydra
0
0
Fork 0
forked from lix-project/hydra
Code Pull requests Activity
3733 commits 1 branch 0 tags 17 MiB
Commit graph

3733 commits

This branch
This branch
All branches
Author SHA1 Message Date
Luke Granger-Brown 67ebce8493 Output evaluation errors without crashing if aggregate job is broken. 
At the moment, aggregate jobs can easily break and cause the entire
evaluation to fail, which is not ideal. For Nixpkgs, we do have some
important aggregate jobs (like `tested`), but for debugging and building
purposes it's still useful to get a partial result even if the channel
won't actually advance.

This commit changes the behaviour of hydra-eval-jobs such that it
aggregates any errors found during the construction of an aggregate, and
will instead annotate the job with the evaluation failure such that it
shows up in a "cleaner" way.

There are really two types of failure that we care about: one is where
the attribute just ends up missing altogether in the final output, and
also where the attribute is in the output but fails to evaluate. Both
are handled here.

Note that this does mean that the same error message may be output
multiple times, but this aids debuggability because it'll be much
clearer what's blocking the job from being created.
 2021-10-26 10:14:34 +01:00
Luke Granger-Brown f2b51a017b Test Setup: fix evalSucceeds to actually output evaluation errors 
At the moment, the jobset object is unlikely to actually retrieve the
evaluation error output, because it isn't refreshed after
hydra-eval-jobsets is run.

Explicitly calling DBIx::Class::Row->discard_changes causes any updated
data to be refreshed, at the cost of losing any not-yet committed
changes to the row.
 2021-10-26 10:13:58 +01:00
Graham Christensen d52e397503 Builds controller: add a test for restarting builds, fix restarting builds 2021-10-25 22:22:08 -04:00
Graham Christensen ffedbe5996 restart/cancelBuilds: always pass resultsets explicitly 2021-10-25 22:21:48 -04:00
Graham Christensen 592fef9d82
Merge pull request #1049 from DeterminateSystems/drop-systemtypes 
SystemTypes: drop database table.
 2021-10-24 21:46:57 -04:00
Graham Christensen 802a5dfe68
Merge pull request #1048 from DeterminateSystems/fixup-1003 
Hydra::Helper::Nix::getMachines: add a test
 2021-10-24 21:38:38 -04:00
Graham Christensen ff888032eb SystemTypes: drop database table. It was originally removed in #65, but put back in fcd511c4de, and now totally unused. 2021-10-24 21:38:04 -04:00
Graham Christensen 5fbf1470bd (perl) machines file: support machine lines with multiple spaces between fields 2021-10-24 21:30:53 -04:00
Graham Christensen b817124337 Hydra::Helper::Nix::getMachines: add a test 
Fix parsing breakage from #1003: assigning the lines to $lines broke chomp and the filters.

This test validates the parsing works as expected, and also fixes
a minor bug where '-' in features isn't pruned, like in the C++
repo.
 2021-10-23 22:53:55 -04:00
Graham Christensen 7fbf5cbd42
Merge pull request #1047 from NixOS/revert-825-fix/unhelpful-errors-in-aggregates 
Revert "Fix unhelpful error messages in aggregate jobs."
 2021-10-23 22:23:40 -04:00
Graham Christensen 8cf158b7a9
Revert "Fix unhelpful error messages in aggregate jobs." 2021-10-23 22:23:29 -04:00
Graham Christensen 3516950d3c
Merge pull request #825 from samueldr/fix/unhelpful-errors-in-aggregates 
Fix unhelpful error messages in aggregate jobs.
 2021-10-23 20:34:50 -04:00
Graham Christensen 30e50010f5
Merge pull request #1044 from DeterminateSystems/perlcritic-level-3 
Perlcritic level 3
 2021-10-20 17:06:26 -04:00
Graham Christensen 5285d0b6cb gittea test: prune trailing space 2021-10-20 13:09:39 -04:00
Graham Christensen d98d74fa4f perlcritic: doesn't like prototypes 2021-10-20 13:09:39 -04:00
Graham Christensen c317ab0dbe shell: add pixz so NAR serving works from foreman 2021-10-20 13:09:39 -04:00
Graham Christensen 7095d00608 perlcritic: make all open() calls three-argument 
Two-argument calls end up parsing the second argument to guess what
should happen, three-arg parses ... less?
 2021-10-20 13:09:39 -04:00
Graham Christensen 43c056bb7b t/TaskDispatcher.t: array / arrayref consistency 
Also fixes a test which was comparing the length of two lists
instead of the values inside the lists. Dang, Perl.
 2021-10-20 11:38:27 -04:00
Graham Christensen a5fa3fccc3 perlcritic: level 3 2021-10-20 10:51:17 -04:00
Graham Christensen f0d0358ee4
Merge pull request #1043 from DeterminateSystems/perl-warnings 
Fixup Perl warnings around undefined variables
 2021-10-20 10:48:05 -04:00
Graham Christensen a887b3d346 fixup! EmailNotification: address Use of uninitialized value in numeric eq (==) 2021-10-20 10:40:08 -04:00
Graham Christensen a36d23c1dd fixup! BitBucketStatus: address Use of uninitialized value in numeric eq (==) 2021-10-20 10:40:08 -04:00
Graham Christensen d5282de131
Merge pull request #1042 from DeterminateSystems/declarative-jobsets-no-jq 
GitHubPulls: output sorted json without using jq
 2021-10-20 10:33:46 -04:00
Graham Christensen 3c38629fad GitHubPulls: output sorted json without using jq 2021-10-20 10:05:31 -04:00
Graham Christensen 30d36da057 CoverityScan: fixup tarballshandle introduced in 21e1ff0da1 2021-10-19 22:04:57 -04:00
Graham Christensen 093e235bf0 GithubRefs: fixup "my" variable $type masks earlier declaration in same scope 2021-10-19 22:02:41 -04:00
Graham Christensen 0f8d02894a hydra-eval-jobset: Scalar value @declInputs[0] better written as $declInputs[0] at hydra-eval-jobset line 570. 2021-10-19 21:52:39 -04:00
Graham Christensen 31cf249aed S3Backup: check for bzip2 and xz Nix Config support (Use of uninitialized value ::Config::xz in concatenation) 2021-10-19 21:52:39 -04:00
Graham Christensen bf692c9e8c BitBucketStatus: address Use of uninitialized value in numeric eq (==) 2021-10-19 21:52:39 -04:00
Graham Christensen 4fd90ec784 EmailNotification: address Use of uninitialized value in numeric eq (==) 2021-10-19 21:52:39 -04:00
Graham Christensen 01112e9bd3 GitInput: deal with undefined deepClone 2021-10-19 21:52:39 -04:00
Eelco Dolstra 2ee584e7ae
Merge pull request #1040 from NixOS/update-api 
Update hydra-api.yaml
 2021-10-12 16:46:16 +02:00
Eelco Dolstra 2e43a9644f Update hydra-api.yaml 2021-10-12 14:31:46 +02:00
Eelco Dolstra 8755321ec7
Merge pull request #1039 from NixOS/return-flake 
/eval: Return more columns
 2021-10-12 14:09:52 +02:00
Eelco Dolstra 888ba467fd /eval: Return more columns 
Fixes #1038.
 2021-10-12 12:41:37 +02:00
Graham Christensen 0be3bed757
Merge pull request #1033 from Mic92/plugins 
add basic documentation for all plugins
 2021-10-08 09:17:41 -04:00
Jörg Thalheim 243291f9bd add basic documentation for all plugins 
Co-authored-by: Pablo Ovelleiro Corral <mail@pablo.tools>
Co-authored-by: Graham Christensen <graham@grahamc.com>
 2021-10-03 13:56:44 +02:00
Graham Christensen dcee1a35ad
Merge pull request #1035 from DeterminateSystems/fixup-perlcritic-after-constituents 
constituents test: add use warnings
 2021-09-30 09:41:27 -04:00
Graham Christensen 3990bd12e9 constituents test: add use warnings 
This is causing CI to fail after #1026 merged. #1026 had a green
bill of health, but #1003 increased perlcritic to level 4. #1003
was not part of #1026 so it was not checked at perlcritic level 4.
 2021-09-30 09:13:01 -04:00
Graham Christensen 4c8279044b
Merge pull request #1026 from DeterminateSystems/constituents 
add api endpoint: /build/<id>/constituents
 2021-09-28 09:21:21 -04:00
Eelco Dolstra 19e668b7cd
Merge pull request #981 from jonringer/pure_eval 
Allow for evaluator_pure_eval to be configured
 2021-09-27 20:25:01 +02:00
Eelco Dolstra 2745226ada
Merge pull request #1003 from DeterminateSystems/perlcritic-level-4 
perlcritic: level 4
 2021-09-27 20:23:55 +02:00
Eelco Dolstra 37af3e69eb
Merge pull request #1030 from NixOS/ublock 
Fix 'Error loading tab: 0 error' with uBlock Origin
 2021-09-27 20:21:39 +02:00
Eelco Dolstra b622337186
Merge pull request #1029 from NixOS/fix-make 
Fix building $(srcdir)/static
 2021-09-27 17:45:01 +02:00
Eelco Dolstra 66375fd2d9 Fix 'Error loading tab: 0 error' with uBlock Origin 
/metrics-tab matches a rule in one of uBlock Origin's default
blocklists, so let's name it something else.
 2021-09-27 17:42:56 +02:00
Eelco Dolstra 9bb3e30a46 Fix building $(srcdir)/static 
Fixes

  mv: cannot move './static/bootstrap-4.3.1-dist' to './static/bootstrap/bootstrap-4.3.1-dist': Directory not empty

when 'make' is called more than once.
 2021-09-27 17:01:25 +02:00
Graham Christensen b550145967
Merge pull request #1017 from Ma27/compare-full 
jobset-eval: pass `full` parameter to "Compare to..."
 2021-09-24 22:00:05 -04:00
Graham Christensen 8d7116522f
Merge pull request #1024 from Ma27/hydra-home-creation 
hydra-module: don't use `createHome = true;` to create Hydra's base-dir
 2021-09-24 21:59:26 -04:00
Graham Christensen c60c8d10ea add api endpoint: /build/<id>/constituents 
Returns a list of constituent builds
 2021-09-24 16:30:44 -04:00
Graham Christensen 99161c7c53
Merge pull request #1012 from helsinki-systems/fix/ldap-test 
fix ldap nixos test
 2021-09-24 14:27:26 -04:00