vriska/hydra
0
0
Fork 0
forked from lix-project/hydra
Code Pull requests Activity

Don't send gitea status update when build is started

Browse source 
This was the source of a flaky test because sometimes hydra-notify was
quick enough to send out `buildStarted` and sometimes it apparently
wasn't which was quickly spottable with `nix build --rebuild`.

Removing that status update doesn't make a difference functionally,
gitea doesn't differentiate between "queued" and "running", so we send
the same status ("pending") out on both events, so we'd even safe one
avoidable request.

(cherry picked from commit 806c375c338b4e6a1d276b96994018908784bf11)
This commit is contained in:
Maximilian Bosch 2024-03-08 11:07:38 +01:00 committed by Pierre Bourdon
parent 925dc7544a
commit aff354e32f
Signed by untrusted user: delroth
GPG key ID: 6FB80DCD84DA0F1C
2 changed files with 2 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
flake.nix
View file

@ -348,10 +348,9 @@
response = json.loads(data)
assert len(response) == 3, "Expected exactly three status updates for latest commit (queued, started, finished)!"
assert len(response) == 2, "Expected exactly three status updates for latest commit (queued, finished)!"
assert response[0]['status'] == "success", "Expected finished status to be success!"
assert response[1]['status'] == "pending", "Expected started status to be pending!"
assert response[2]['status'] == "pending", "Expected queued status to be pending!"
assert response[1]['status'] == "pending", "Expected queued status to be pending!"
machine.shutdown()
'';

4
src/lib/Hydra/Plugin/GiteaStatus.pm
View file

@ -88,10 +88,6 @@ sub buildQueued {
common(@_, [], 0);
}
sub buildStarted {
common(@_, [], 1);
}
sub buildFinished {
common(@_, 2);
}