vriska/hydra
0
0
Fork 0
forked from lix-project/hydra
Code Pull requests Activity

Make latest/latest-for more efficient

Browse source 
Getting all matching rows from the database is expensive.
This commit is contained in:
Eelco Dolstra 2013-05-23 12:18:38 -04:00
parent 7b5e92868b
commit 5e5b344527
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/lib/Hydra/Base/Controller/ListBuilds.pm
View file

@ -96,8 +96,8 @@ sub nix : Chained('get_builds') PathPart('channel') CaptureArgs(1) {
sub latest : Chained('get_builds') PathPart('latest') {
my ($self, $c, @rest) = @_;
my ($latest) = $c->stash->{allBuilds}->search(
{finished => 1, buildstatus => 0}, {order_by => ["id DESC"]});
my $latest = $c->stash->{allBuilds}->find(
{ finished => 1, buildstatus => 0 }, { order_by => ["id DESC"], rows => 1 });
notFound($c, "There is no successful build to redirect to.") unless defined $latest;
@ -111,8 +111,8 @@ sub latest_for : Chained('get_builds') PathPart('latest-for') {
notFound($c, "You need to specify a platform type in the URL.") unless defined $system;
my ($latest) = $c->stash->{allBuilds}->search(
{finished => 1, buildstatus => 0, system => $system}, {order_by => ["id DESC"]});
my $latest = $c->stash->{allBuilds}->find(
{ finished => 1, buildstatus => 0, system => $system }, { order_by => ["id DESC"], rows => 1 });
notFound($c, "There is no successful build for platform `$system' to redirect to.") unless defined $latest;