vriska/hydra
0
0
Fork 0
forked from lix-project/hydra
Code Pull requests Activity

Hide build IDs from build lists

Browse source 
Like eval IDs, build IDs don't convey useful information.

Also, make the job name link to the build rather than the job. When
people click on a build, they expect to go to the build page, not the
job page.
This commit is contained in:
Eelco Dolstra 2015-02-26 13:28:14 +01:00
parent 62805dd73c
commit 522bcea8fc
1 changed files with 5 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/root/common.tt
View file

@ -77,13 +77,12 @@ BLOCK renderBuildListHeader %]
[% IF showSchedulingInfo %] [% IF showSchedulingInfo %]
<th></th> <th></th>
[% END %] [% END %]
<th>#</th>
[% IF !hideJobName %] [% IF !hideJobName %]
<th>Job</th> <th>Job</th>
[% END %] [% END %]
<th>Release name</th>
<th>System</th>
<th>[% IF showSchedulingInfo %]Queued at[% ELSE %]Finished at[% END %]</th> <th>[% IF showSchedulingInfo %]Queued at[% ELSE %]Finished at[% END %]</th>
<th>Package/release name</th>
<th>System</th>
[% IF showDescription %] [% IF showDescription %]
<th>Description</th> <th>Description</th>
[% END %] [% END %]
@ -94,7 +93,7 @@ BLOCK renderBuildListHeader %]
BLOCK renderBuildListBody; BLOCK renderBuildListBody;
FOREACH build IN builds; %] FOREACH build IN builds; link = c.uri_for('/build' build.id) %]
<tr> <tr>
[% IF !hideResultInfo %] [% IF !hideResultInfo %]
<td> <td>
@ -104,13 +103,12 @@ BLOCK renderBuildListBody;
[% IF showSchedulingInfo %] [% IF showSchedulingInfo %]
<td>[% IF build.busy %]<span class="label label-success">Started</span>[% ELSE %]<span class="label">Queued</span>[% END %]</td> <td>[% IF build.busy %]<span class="label label-success">Started</span>[% ELSE %]<span class="label">Queued</span>[% END %]</td>
[% END %] [% END %]
<td><a class="row-link" href="[% c.uri_for('/build' build.id) %]">[% build.id %]</a></td>
[% IF !hideJobName %] [% IF !hideJobName %]
<td>[% INCLUDE renderFullJobNameOfBuild %]</td> <td><a href="[%link%]">[%build.get_column("project")%]:[%build.get_column("jobset")%]:[%build.get_column("job")%]</td>
[% END %] [% END %]
<td class="nowrap"><a class="row-link" href="[%link%]">[% t = showSchedulingInfo ? build.timestamp : build.stoptime; IF t; INCLUDE renderRelativeDate timestamp=(showSchedulingInfo ? build.timestamp : build.stoptime); ELSE; "-"; END %]</a></td>
<td>[% !showSchedulingInfo and build.get_column('releasename') ? build.get_column('releasename') : build.nixname %]</td> <td>[% !showSchedulingInfo and build.get_column('releasename') ? build.get_column('releasename') : build.nixname %]</td>
<td class="nowrap"><tt>[% build.system %]</tt></td> <td class="nowrap"><tt>[% build.system %]</tt></td>
<td class="nowrap">[% t = showSchedulingInfo ? build.timestamp : build.stoptime; IF t; date.format(showSchedulingInfo ? build.timestamp : build.stoptime, '%Y-%m-%d %H:%M:%S'); ELSE; "-"; END %]</td>
[% IF showDescription %] [% IF showDescription %]
<td>[% build.description %]</td> <td>[% build.description %]</td>
[% END %] [% END %]