From 0f88014631cd61c21095ef55bd1cfbc8f370ff30 Mon Sep 17 00:00:00 2001 From: Graham Christensen Date: Fri, 20 Aug 2021 21:33:32 -0400 Subject: [PATCH] CircleCiNotification: $b -> $build (perlcritic) --- src/lib/Hydra/Plugin/CircleCINotification.pm | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/lib/Hydra/Plugin/CircleCINotification.pm b/src/lib/Hydra/Plugin/CircleCINotification.pm index e9e8623d..398fe066 100644 --- a/src/lib/Hydra/Plugin/CircleCINotification.pm +++ b/src/lib/Hydra/Plugin/CircleCINotification.pm @@ -13,22 +13,22 @@ sub isEnabled { } sub buildFinished { - my ($self, $build, $dependents) = @_; + my ($self, $topbuild, $dependents) = @_; my $cfg = $self->{config}->{circleci}; my @config = defined $cfg ? ref $cfg eq "ARRAY" ? @$cfg : ($cfg) : (); # Figure out to which branches to send notification. my %branches; - foreach my $b ($build, @{$dependents}) { - my $prevBuild = getPreviousBuild($b); - my $jobName = showJobName $b; + foreach my $build ($topbuild, @{$dependents}) { + my $prevBuild = getPreviousBuild($build); + my $jobName = showJobName $build; foreach my $branch (@config) { my $force = $branch->{force}; next unless $jobName =~ /^$branch->{jobs}$/; # If build is failed, don't trigger circleci - next if ! $force && $b->buildstatus != 0; + next if ! $force && $build->buildstatus != 0; my $fullUrl = "https://circleci.com/api/v1.1/project/" . $branch->{vcstype} . "/" . $branch->{username} . "/" . $branch->{project} . "/tree/" . $branch->{branch} . "?circle-token=" . $branch->{token}; $branches{$fullUrl} = 1;