Commit graph

1256 commits

Author SHA1 Message Date
Graham Christensen 041d96d890
Merge pull request #470 from cole-h/missing-variants
ghevent: add missing variants
2020-04-24 17:33:06 -04:00
Graham Christensen b4afb127df
Merge pull request #469 from LnL7/cargo-workspace
introduce cargo workspace
2020-04-24 17:24:42 -04:00
Cole Helbling db165abf99
ghevent: add missing variants
So we don't see log messages that are literal pages long. Pulled from
here: https://developer.github.com/v3/activity/events/types/#pullrequestevent
2020-04-24 14:18:21 -07:00
Daiderd Jordan 7ccb4943a1
move simple-build to a separate project
This is mostly intended as an example and since this is only useful for
testing it should be relatively safe.
2020-04-24 22:17:12 +02:00
Daiderd Jordan 1c0c5e304c
init cargo workspace
Enables splittig up the code a bit more, and hopefully helps keep the
compilation time down.
2020-04-24 21:27:33 +02:00
Graham Christensen 329a08f53d
Merge pull request #468 from emilazy/trust-emily
config.public.json: add emilazy to trusted_users
2020-04-23 15:19:08 -04:00
Graham Christensen d823531dea
Merge pull request #425 from marsam/marsam-trusted-users
config.public.json: add marsam to trusted_users
2020-04-23 15:18:56 -04:00
Emily 650f0912d8 config.public.json: add emilazy to trusted_users 2020-04-23 20:17:11 +01:00
Graham Christensen b3a3b4b0ee
Merge pull request #467 from cole-h/unbump
Revert "Bump amqp"
2020-04-23 11:39:21 -04:00
Cole Helbling a3475d1c0d
Revert "Bump amqp"
This reverts commit fa299dedaa.
2020-04-23 08:21:34 -07:00
Graham Christensen 98455feb18
Merge pull request #464 from cole-h/bump
Bump amqp
2020-04-22 16:24:24 -04:00
Cole Helbling fa299dedaa
Bump amqp
Hopefully this will deal with (or at least help address) our
`SendError(..)` panics and log collector unavailability.
2020-04-22 09:53:53 -07:00
Graham Christensen 0581cc59ed
Merge pull request #462 from doronbehar/patch-1
config.public.json: add @doronbehar
2020-04-20 07:49:02 -04:00
Graham Christensen b8e39f7d22
Merge pull request #460 from cole-h/nix1-removal
Nix1 removal
2020-04-20 07:48:51 -04:00
Doron Behar bd80f1fe58
config.public.json: add @doronbehar
Per @domenkozar 's comment:
https://github.com/NixOS/nixpkgs/issues/50105#issuecomment-614886167
2020-04-17 12:35:24 +00:00
Cole Helbling f5e0318f9f
nix: fix failing test
Nix 2.3.4 now shows the assertion that failed since NixOS/nix@307bcb9, changing
the message we need to check against.
2020-04-12 11:06:16 -07:00
Cole Helbling 35bb3a8975
Remove nix1
As of NixOS/nixpkgs@7121160, nix1 has been removed from Nixpkgs. Thus, we
remove it here.
2020-04-12 11:04:40 -07:00
Graham Christensen a095c36668
Merge pull request #458 from cole-h/logging
{checkout,clone}: redirect output to /dev/null
2020-04-09 17:23:20 -04:00
Cole Helbling b33d3de6cf
tasks/evaluate: show issue number not id
The `id` field is not the GitHub PR or issue number; the `number` field
is.
2020-04-09 14:06:58 -07:00
Cole Helbling db190207a2
{checkout,clone}: redirect output to /dev/null
It fills the logs with typically-useless information. We don't really
care about the novels people write in their commit messages.

The only `git` commands that were left unmodified are the ones where we
use their output in some way (and thus, it isn't printed to stdout/err
anyways).
2020-04-09 13:47:10 -07:00
Graham Christensen 83d748169c
Merge pull request #457 from cole-h/logging
More logging
2020-04-07 16:39:28 -04:00
Cole Helbling 5de114c151
tasks/build: don't use \n to split log line
Otherwise, we have one line that has the log prefix, and one line
immediately following that doesn't.
2020-04-07 13:27:37 -07:00
Cole Helbling 5fd48be23d
tasks/eval/nixpkgs: don't request review from PR author
GitHub doesn't let us, so we silently skip them.
2020-04-07 13:27:21 -07:00
Graham Christensen 284a7bfeaa
Merge pull request #456 from NixOS/retryon-bad-creds
Retry on bad creds
2020-04-07 08:29:02 -04:00
Graham Christensen 3dc7498211
retry a job if we get an expired creds error 2020-04-07 08:16:08 -04:00
Graham Christensen e65a24aa89
commitstatuserror: handle each error case separately, not based on 'internal' error 2020-04-07 08:14:02 -04:00
Graham Christensen b4989e44f8
Merge pull request #455 from cole-h/logging
Cargo.toml: enable debug symbols in release profile
2020-04-06 16:18:53 -04:00
Cole Helbling 8e284c5b6b
Cargo.toml: enable debug symbols in release profile
Maybe now we'll be able to read the backtraces generated by
`error-chain` via `hubcaps`.
2020-04-06 13:01:40 -07:00
Graham Christensen dd38e6e2ec
Merge pull request #454 from NixOS/label-log
labeling: make log messages one-line
2020-04-06 12:42:00 -04:00
Graham Christensen 3bc29be475
labeling: make log messages one-line 2020-04-06 10:52:32 -04:00
Graham Christensen 8e6f78607b
Merge pull request #453 from NixOS/handle-errs-better
Handle errs better
2020-04-06 07:20:57 -04:00
Graham Christensen a1e8dcc1e5
evaluate: handle evaluation errors, and posting errors while posting eval errors better 2020-04-06 07:05:56 -04:00
Graham Christensen 00478e9dee
update_status: also return a CommitStatusError 2020-04-06 07:02:49 -04:00
Graham Christensen f02c7382cc
commitstatus: distinguish internal and external error factors 2020-04-06 07:02:45 -04:00
Graham Christensen 2541d183bf
Merge pull request #452 from cole-h/logging
Logging cleanup
2020-04-06 06:00:48 -04:00
Cole Helbling c9d4bb1fd8
bin/*: replace {e,}println!s with log macros
May as well be consistent.
2020-04-05 23:52:21 -07:00
Cole Helbling 1b8cec63f2
treewide: replace {e,}println!s with log macros
Currently, our logs are a bit inconsistent, with some being
`{e,}println!`s and others utilizing macros from the `log` crate. One
line might look like `INFO:ofborg::tasks::evaluate: Removing labels:
[]`, while the next might look like `Already: []`.
2020-04-05 23:52:21 -07:00
Cole Helbling 5c1a85ca31
treewide: replace {:#?} with {:?}
Cleans up logging output so that things that belong together stay
together.
2020-04-05 12:32:19 -07:00
Graham Christensen e26497e49d
Merge pull request #451 from LnL7/eval-no-nixpkgs
rename nixpkgs entry in NIX_PATH
2020-04-05 15:06:55 -04:00
Daiderd Jordan f6c22bfc4f
rename nixpkgs entry in NIX_PATH
This ensures the local sources are still allowed in restricted mode, but
referencing <nixpkgs> in expressions inside nixpkgs is not.
2020-04-05 20:09:34 +02:00
Graham Christensen b55535a608
Merge pull request #450 from cole-h/silence-diffs
checkout: silence diffs when checking validity of a commit
2020-04-05 13:27:30 -04:00
Cole Helbling a907ffb488
checkout: silence diffs when checking validity of a commit
Otherwise, when people submit treewide PRs to nixpkgs, the logs get
cluttered with thousands of useless diffs.
2020-04-05 09:44:19 -07:00
Graham Christensen 91f6aee4d5
Merge pull request #449 from cole-h/ignore-remove-file
nixenv: warn when removing the stats file fails
2020-04-03 20:45:55 -04:00
Cole Helbling 9736cf08fe
nixenv: remove unnecessary single quotes
The debug representation of a `PathBuf` provides double quotes already.
2020-04-03 17:37:21 -07:00
Cole Helbling 42b4bb2118
nixenv: warn when removing the stats file fails
If the `nix` invocation fails, a stats file won't get created. We log a
warning, but it is generally safe to ignore this failure.
2020-04-03 17:25:58 -07:00
Graham Christensen 0db6f70714
Merge pull request #448 from cole-h/bump
Bump hubcaps
2020-04-03 19:55:28 -04:00
Cole Helbling 2649658fe8
Bump hubcaps
New hubcaps update makes `created_at` and `updated_at` fields optional,
because sometimes they just aren't there.
2020-04-03 16:39:52 -07:00
Graham Christensen 85988113aa
Merge pull request #447 from cole-h/nix-env-describe
nixenv: describe what went wrong when io fails
2020-04-03 14:07:14 -04:00
Cole Helbling 9dc0fd123a
match -> map_err 2020-04-03 10:51:02 -07:00
Cole Helbling 2b2b675011
nixenv: describe what went wrong when io fails
Instead of just propagating a raw `std::io::Error`, wrap that in our own
`Error` enum to provide more context for what actually went wrong.
2020-04-03 10:34:01 -07:00