the-distro/ofborg
2
0
Fork 1
Code Issues 1 Pull requests 1 Packages Projects Releases Wiki Activity

request reviews one at a time

Browse source 
if a batch of review requests contains any users who are not members of the organization, the entire request fails.
This commit is contained in:
Graham Christensen 2019-01-16 08:32:03 -05:00
parent 22e7d0ae8d
commit f151c71ebb
No known key found for this signature in database
GPG key ID: ACA1C1D120C83D5C
1 changed files with 10 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
ofborg/src/tasks/massrebuilder.rs
View file

@ -737,18 +737,16 @@ fn request_reviews(
) { ) {
if let Ok(ref maint) = m { if let Ok(ref maint) = m {
if maint.maintainers().len() < 10 { if maint.maintainers().len() < 10 {
for maintainer in maint.maintainers() {
if let Err(e) = if let Err(e) =
pull.review_requests() pull.review_requests()
.create(&hubcaps::review_requests::ReviewRequestOptions { .create(&hubcaps::review_requests::ReviewRequestOptions {
reviewers: maint.maintainers(), reviewers: vec![maintainer.clone()],
team_reviewers: vec![], team_reviewers: vec![],
}) })
{ {
println!( println!("Failure requesting a review from {}: {:#?}", maintainer, e,);
"Failure adding review requests for maintainers ({:?}): {:#?}", }
maint.maintainers(),
e,
);
} }
} }
} }