From df100542d453edfaa57a21368d0bafb4da07a455 Mon Sep 17 00:00:00 2001
From: Graham Christensen <graham@grahamc.com>
Date: Sun, 18 Mar 2018 16:25:02 -0400
Subject: [PATCH] Link to the full log if there are any log lines

---
 ofborg/src/tasks/githubcommentposter.rs | 48 ++++++++++++++++++++++---
 1 file changed, 44 insertions(+), 4 deletions(-)

diff --git a/ofborg/src/tasks/githubcommentposter.rs b/ofborg/src/tasks/githubcommentposter.rs
index 306c2c4..ef50b67 100644
--- a/ofborg/src/tasks/githubcommentposter.rs
+++ b/ofborg/src/tasks/githubcommentposter.rs
@@ -74,15 +74,16 @@ impl worker::SimpleWorker for GitHubCommentPoster {
 fn result_to_comment(result: &BuildResult) -> String {
     let mut reply: Vec<String> = vec![];
 
-    let log_link = match result.success {
-        Some(_) => format!(
+    let log_link = if result.output.len() > 0 {
+        format!(
             " [(full log)](https://logs.nix.ci/?key={}/{}.{}&attempt_id={})",
             &result.repo.owner.to_lowercase(),
             &result.repo.name.to_lowercase(),
             result.pr.number,
             result.attempt_id,
-        ),
-        None => "".to_owned()
+        )
+    } else {
+        "".to_owned()
     };
 
     reply.push(format!(
@@ -390,6 +391,45 @@ patching script interpreter paths in /nix/store/pcja75y9isdvgz5i00pkrpif9rxzxc29
 
     #[test]
     pub fn test_no_attempt() {
+        let result = BuildResult {
+            repo: Repo {
+                clone_url: "https://github.com/nixos/nixpkgs.git".to_owned(),
+                full_name: "NixOS/nixpkgs".to_owned(),
+                owner: "NixOS".to_owned(),
+                name: "nixpkgs".to_owned(),
+            },
+            pr: Pr {
+                head_sha: "abc123".to_owned(),
+                number: 2345,
+                target_branch: Some("master".to_owned()),
+            },
+            output: vec!["foo".to_owned()],
+            attempt_id: "foo".to_owned(),
+            system: "x86_64-linux".to_owned(),
+            attempted_attrs: None,
+            skipped_attrs: Some(vec!["not-attempted".to_owned()]),
+            success: None,
+        };
+
+        assert_eq!(
+            &result_to_comment(&result),
+            "No attempt on x86_64-linux [(full log)](https://logs.nix.ci/?key=nixos/nixpkgs.2345&attempt_id=foo)
+
+The following builds were skipped because they don't evaluate on x86_64-linux: not-attempted
+
+<details><summary>Partial log (click to expand)</summary><p>
+
+```
+foo
+```
+</p></details>
+
+"
+        );
+    }
+
+    #[test]
+    pub fn test_no_attempt_no_log() {
         let result = BuildResult {
             repo: Repo {
                 clone_url: "https://github.com/nixos/nixpkgs.git".to_owned(),