the-distro/ofborg
2
0
Fork 1
Code Issues 5 Pull requests 1 Projects Releases Packages Wiki Activity

Send review requests

Browse source
This commit is contained in:
Graham Christensen 2019-01-03 11:58:37 -05:00
parent 9dbb1c4b94
commit b788084512
No known key found for this signature in database
GPG key ID: ACA1C1D120C83D5C
2 changed files with 37 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
ofborg/src/maintainers.rs
View file

@ -73,6 +73,13 @@ impl ImpactedMaintainers {
Ok(serde_json::from_str(&String::from_utf8(ret.stdout)?)?)
}
pub fn maintainers(&self) -> Vec<String> {
self.0
.iter()
.map(|(maintainer, _)| maintainer.0.clone())
.collect()
}
}
impl std::fmt::Display for ImpactedMaintainers {

32
ofborg/src/tasks/massrebuilder.rs
View file

@ -3,6 +3,7 @@ extern crate amqp;
extern crate env_logger;
extern crate uuid;
use crate::maintainers;
use crate::maintainers::ImpactedMaintainers;
use amqp::protocol::basic::{BasicProperties, Deliver};
use hubcaps;
@ -118,6 +119,8 @@ impl<E: stats::SysEvents + 'static> worker::SimpleWorker for MassRebuildWorker<E
.github
.repo(job.repo.owner.clone(), job.repo.name.clone());
let gists = self.github.gists();
let pulls = repo.pulls();
let pull = pulls.get(job.pr.number);
let issue = repo.issue(job.pr.number);
let auto_schedule_build_archs: Vec<buildjob::ExchangeQueue>;
@ -541,11 +544,13 @@ impl<E: stats::SysEvents + 'static> worker::SimpleWorker for MassRebuildWorker<E
"Potential Maintainers",
Some("".to_owned()),
match m {
Ok(maintainers) => format!("Maintainers:\n{}", maintainers),
Err(e) => format!("Ignorable calculation error:\n{:?}", e),
Ok(ref maintainers) => format!("Maintainers:\n{}", maintainers),
Err(ref e) => format!("Ignorable calculation error:\n{:?}", e),
},
);
request_reviews(&m, &pull);
let mut status = CommitStatus::new(
repo.statuses(),
job.pr.head_sha.clone(),
@ -725,3 +730,26 @@ fn indicates_wip(text: &str) -> bool {
false
}
fn request_reviews(
m: &Result<maintainers::ImpactedMaintainers, maintainers::CalculationError>,
pull: &hubcaps::pulls::PullRequest,
) {
if let Ok(ref maint) = m {
if maint.maintainers().len() < 10 {
if let Err(e) =
pull.review_requests()
.create(&hubcaps::review_requests::ReviewRequestOptions {
reviewers: maint.maintainers(),
team_reviewers: vec![],
})
{
println!(
"Failure adding review requests for maintainers ({:?}): {:#?}",
maint.maintainers(),
e,
);
}
}
}
}