Merge pull request #348 from NixOS/fix/fail-with-github

set_with_description actually does the thing, set_url is lies
This commit is contained in:
Graham Christensen 2019-04-11 21:35:31 -04:00 committed by GitHub
commit b3a924b100
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 1 deletions

View file

@ -1,4 +1,9 @@
#![recursion_limit = "512"] #![recursion_limit = "512"]
// Replacing .map(|arch| arch.to_string())
// with .map(systems::System::to_string)
//
// seems much less clear and I just don't like it :)
#![allow(clippy::redundant_closure)]
#[macro_use] #[macro_use]
extern crate serde_derive; extern crate serde_derive;

View file

@ -70,8 +70,8 @@ impl<E: stats::SysEvents> EvaluationWorker<E> {
Err(()) Err(())
} }
Err(eval::Error::FailWithGist(msg, filename, content)) => { Err(eval::Error::FailWithGist(msg, filename, content)) => {
status.set_with_description(&msg, hubcaps::statuses::State::Failure);
status.set_url(make_gist(&gists, &filename, Some("".to_owned()), content)); status.set_url(make_gist(&gists, &filename, Some("".to_owned()), content));
status.set_with_description(&msg, hubcaps::statuses::State::Failure);
Err(()) Err(())
} }
} }