Merge pull request #453 from NixOS/handle-errs-better

Handle errs better

ofborg/src/commitstatus.rs

@@ -65,11 +65,36 @@ impl<'a> CommitStatus<'a> {
                     .build(),
             )
             .map(|_| ())
-            .map_err(|e| CommitStatusError::HubcapsError(e))
+            .map_err(|e| CommitStatusError::from(e))
     }
 }
 
 #[derive(Debug)]
 pub enum CommitStatusError {
-    HubcapsError(hubcaps::Error),
+    MissingSHA(hubcaps::Error),
+    Error(hubcaps::Error),
+}
+
+impl CommitStatusError {
+    pub fn is_internal_error(&self) -> bool {
+        match self {
+            CommitStatusError::MissingSHA(_) => false,
+            CommitStatusError::Error(_) => true,
+        }
+    }
+}
+
+impl From<hubcaps::Error> for CommitStatusError {
+    fn from(e: hubcaps::Error) -> CommitStatusError {
+        use hyper::status::StatusCode;
+        match e.kind() {
+            hubcaps::ErrorKind::Fault { code, error }
+                if code == &StatusCode::UnprocessableEntity
+                    && error.message.starts_with("No commit found for SHA:") =>
+            {
+                CommitStatusError::MissingSHA(e)
+            }
+            _otherwise => CommitStatusError::Error(e),
+        }
+    }
 }

ofborg/src/tasks/evaluate.rs

@@ -161,7 +161,7 @@ impl<'a, E: stats::SysEvents + 'static> OneEval<'a, E> {
         description: String,
         url: Option<String>,
         state: hubcaps::statuses::State,
-    ) -> Result<(), hubcaps::Error> {
+    ) -> Result<(), CommitStatusError> {
         let description = if description.len() >= 140 {
             warn!(
                 "description is over 140 char; truncating: {:?}",
@@ -189,6 +189,7 @@ impl<'a, E: stats::SysEvents + 'static> OneEval<'a, E> {
             .statuses()
             .create(&self.job.pr.head_sha, &builder.build())
             .map(|_| ())
+            .map_err(|e| CommitStatusError::from(e))
     }
 
     fn make_gist(
@@ -201,53 +202,48 @@ impl<'a, E: stats::SysEvents + 'static> OneEval<'a, E> {
     }
 
     fn worker_actions(&mut self) -> worker::Actions {
-        let eval_result = self.evaluate_job();
+        let eval_result = self.evaluate_job().map_err(|eval_error| match eval_error {
-        if let Ok(actions) = eval_result {
+            // Handle error cases which expect us to post statuses
-            return actions;
+            // to github. Convert Eval Errors in to Result<_, CommitStatusWrite>
+            EvalWorkerError::EvalError(eval::Error::Fail(msg)) => {
+                self.update_status(msg, None, hubcaps::statuses::State::Failure)
             }
-        let eval_result =
+            EvalWorkerError::EvalError(eval::Error::FailWithGist(msg, filename, content)) => self
-            eval_result.expect_err("We have an OK, but just checked for an Ok before");
+                .update_status(
+                    msg,
+                    self.make_gist(&filename, Some("".to_owned()), content),
+                    hubcaps::statuses::State::Failure,
+                ),
+            EvalWorkerError::EvalError(eval::Error::CommitStatusWrite(e)) => Err(e),
+            EvalWorkerError::CommitStatusWrite(e) => Err(e),
+        });
 
         match eval_result {
-            EvalWorkerError::CommitStatusWrite(e) => {
+            Ok(eval_actions) => eval_actions,
-                error!(
+            Err(Ok(())) => {
-                    "Failed to write commit status, got error: {:?}, marking internal error",
+                // There was an error during eval, but we successfully
-                    e
+                // updated the PR.
-                );
-                let issue_ref = self.repo.issue(self.job.pr.number);
-                update_labels(&issue_ref, &[String::from("ofborg-internal-error")], &[]);
-            }
-            EvalWorkerError::EvalError(eval::Error::CommitStatusWrite(e)) => {
-                error!(
-                    "Failed to write commit status, got error: {:?}, marking internal error",
-                    e
-                );
-                let issue_ref = self.repo.issue(self.job.pr.number);
-                update_labels(&issue_ref, &[String::from("ofborg-internal-error")], &[]);
-            }
-            EvalWorkerError::EvalError(eval::Error::Fail(msg)) => {
-                self.update_status(msg.clone(), None, hubcaps::statuses::State::Failure)
-                    .unwrap_or_else(|e| {
-                        panic!("Failed to set plain status: {}; e: {:?}", msg, e);
-                    });
-            }
-            EvalWorkerError::EvalError(eval::Error::FailWithGist(msg, filename, content)) => {
-                self.update_status(
-                    msg.clone(),
-                    self.make_gist(&filename, Some("".to_owned()), content.clone()),
-                    hubcaps::statuses::State::Failure,
-                )
-                .unwrap_or_else(|e| {
-                    panic!(
-                        "Failed to set status with a gist: {}, {}, {}; e: {:?}",
-                        msg, filename, content, e
-                    );
-                });
-            }
-        }
 
                 self.actions().skip(&self.job)
             }
+            Err(Err(cswerr)) if !cswerr.is_internal_error() => {
+                error!("Ignorable error writing commit status: {:?}", cswerr);
+
+                self.actions().skip(&self.job)
+            }
+
+            Err(Err(cswerr)) => {
+                error!(
+                    "Internal error writing commit status: {:?}, marking internal error",
+                    cswerr
+                );
+                let issue_ref = self.repo.issue(self.job.pr.number);
+                update_labels(&issue_ref, &[String::from("ofborg-internal-error")], &[]);
+
+                self.actions().skip(&self.job)
+            }
+        }
+    }
 
     fn evaluate_job(&mut self) -> Result<worker::Actions, EvalWorkerError> {
         let job = self.job;