the-distro/ofborg
2
0
Fork 1
Code Issues 1 Pull requests 1 Packages Projects Releases Wiki Activity

Revert "Revert "commitstatus: return an error if we fail to set a status""

Browse source 
This reverts commit cf28b411f2.
This commit is contained in:
Graham Christensen 2020-03-31 18:46:34 -04:00
parent a8eb1743b0
commit 85649b0c79
No known key found for this signature in database
GPG key ID: FE918C3A98C1030F
1 changed files with 13 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
ofborg/src/commitstatus.rs
View file

@ -36,16 +36,20 @@ impl<'a> CommitStatus<'a> {
self.url = url.unwrap_or_else(|| String::from("")) self.url = url.unwrap_or_else(|| String::from(""))
} }
pub fn set_with_description(&mut self, description: &str, state: hubcaps::statuses::State) { pub fn set_with_description(
&mut self,
description: &str,
state: hubcaps::statuses::State,
) -> Result<(), CommitStatusError> {
self.set_description(description.to_owned()); self.set_description(description.to_owned());
self.set(state); self.set(state)
} }
pub fn set_description(&mut self, description: String) { pub fn set_description(&mut self, description: String) {
self.description = description; self.description = description;
} }
pub fn set(&self, state: hubcaps::statuses::State) { pub fn set(&self, state: hubcaps::statuses::State) -> Result<(), CommitStatusError> {
let desc = if self.description.len() >= 140 { let desc = if self.description.len() >= 140 {
eprintln!( eprintln!(
"Warning: description is over 140 char; truncating: {:?}", "Warning: description is over 140 char; truncating: {:?}",
@ -65,6 +69,11 @@ impl<'a> CommitStatus<'a> {
.target_url(self.url.clone()) .target_url(self.url.clone())
.build(), .build(),
) )
.expect("Failed to mark final status on commit"); .map(|_| ())
.map_err(|e| CommitStatusError::HubcapsError(e))
} }
} }
pub enum CommitStatusError {
HubcapsError(hubcaps::Error),
}