Abstract BuildStatus -> String

ofborg/src/message/buildresult.rs

@@ -9,6 +9,18 @@ pub enum BuildStatus {
     UnexpectedError { err: String },
 }
 
+impl From<BuildStatus> for String {
+    fn from(status: BuildStatus) -> String {
+        match status {
+            BuildStatus::Skipped => "No attempt".into(),
+            BuildStatus::Success => "Success".into(),
+            BuildStatus::Failure => "Failure".into(),
+            BuildStatus::TimedOut => "Timed out, unknown build status".into(),
+            BuildStatus::UnexpectedError { ref err } => format!("Unexpected error: {}", err),
+        }
+    }
+}
+
 pub struct LegacyBuildResult {
     pub repo: Repo,
     pub pr: Pr,

ofborg/src/tasks/githubcommentposter.rs

@@ -166,13 +166,7 @@ fn result_to_comment(result: &LegacyBuildResult) -> String {
     reply.push(format!("<!--REQUEST_ID={}-->", result.request_id));
     reply.push(format!(
         "{} on {}{}",
-        (match result.status {
+        String::from(result.status.clone()),
-            BuildStatus::Skipped => "No attempt".into(),
-            BuildStatus::Success => "Success".into(),
-            BuildStatus::Failure => "Failure".into(),
-            BuildStatus::TimedOut => "Timed out, unknown build status".into(),
-            BuildStatus::UnexpectedError { ref err } => format!("Unexpected error: {}", err),
-        }),
         result.system,
         log_link
     ));