3.12 with FOD fix #7
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "lheckemann/nix-gerrit:3_12-with-fod-fix"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This includes #6, and includes a hack to avoid discrepancies between bazel cache builds using different versions of bazel. This may not be sound, would be nice if someone who knows what they're doing could take a look.
@ -0,0 +88,4 @@# version, breaking hashes), but isn't actually needed for the# build. So let's remove that specific path.lcov_merger_tools_path=$(grep -rl all_lcov_merger_tools_deploy.jar $out | head -n1)rm -r "$(dirname "$lcov_merger_tools_path")"This seems fine - lcov merger tools should only be used for
bazel coverage, so I'm happy with this.@ -67,7 +67,6 @@ letrunHook preInstallmkdir $outecho "${bazel.version}" > $out/bazel_versionI'm a bit worried about this in general, since we really should probably be regenerating the FOD after an upstream bazel version change, but I'm willing to give it a go.
Maybe we should put the major version in here and assume that minor versions won't change FOD resolution that much?
Maybe let's do it only on MAJOR version, not minor?
Whatever we use, I think we should also put it in the drv name so we don't get spurious successes that don't bite us until much further down the line.