the-distro/infra
9
0
Fork 5
Code Issues 39 Pull requests 8 Packages Projects 1 Releases Wiki Activity

Check YAML validity of Alert files at evaluation time #94

New issue
Closed
opened 2024-08-09 14:26:33 +00:00 by raito · 2 comments
raito commented 2024-08-09 14:26:33 +00:00
Owner
Copy link

At evaluation time, we need to check the YAML validity of the alert definition files, we should not wait for Alertmanager to tell us "sowwy" until we get a proper Nix DSL to write alerts.

YAML is too complicated to be used without a proper annoying checkPhase.

**At evaluation time**, we need to check the YAML validity of the alert definition files, we should not wait for Alertmanager to tell us "sowwy" until we get a proper Nix DSL to write alerts. YAML is too complicated to be used without a proper annoying `checkPhase`.
janik commented 2024-08-22 23:38:24 +00:00
Owner
Copy link

Why use yaml in the first place? We could just write the same information as nix expresssion and do buitlins.toJSON in https://git.lix.systems/the-distro/infra/src/branch/main/services/monitoring/lgtm/mimir.nix#L63

I know it's not as good as having a module for the alerts or having something like dns.nix or nixos-dns just for alerts but it'd still be better then importing pure yaml and running a yaml linter over that.

Why use yaml in the first place? We could just write the same information as nix expresssion and do buitlins.toJSON in https://git.lix.systems/the-distro/infra/src/branch/main/services/monitoring/lgtm/mimir.nix#L63 I know it's not as good as having a module for the alerts or having something like dns.nix or nixos-dns just for alerts but it'd still be better then importing pure yaml and running a yaml linter over that.
raito commented 2024-08-23 15:39:00 +00:00
Author
Owner
Copy link

@janik I'm fine with this as well, but it doesn't change much there's a checkPhase! :P

@janik I'm fine with this as well, but it doesn't change much there's a `checkPhase`! :P
raito closed this issue 2024-10-10 13:30:00 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
ofborg
revert-to-bash
vault
storage-project
block-crawlers
fix-buildbot
lukegb/rule-94
cache-lix
build02-lix
lukegb/uptime-kuma-root
hydra-metrics
builder
email-groups
cache-ipv4
format
hexchen/colmena-checker
hexy/credentials
buildbot
ckie/moarr-v4
gerrit-metrics
moar-builders
unplug-epyc
hydra-wire-up
alertmanager
fodwatch
cadvisor-containers
gerrit-http-clones
meta01
No results found.
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: the-distro/infra#94
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?